Make kind argument in CFTimeIndex._maybe_cast_slice_bound optional
#5359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @spencerkclark! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-05-22 23:58:02 UTC |
spencerkclark
force-pushed
the
remove-deprecated-kind-arg
branch
from
e52aee9 to
591263e
Compare
keewis
approved these changes
May 22, 2021
Collaborator
keewis
left a comment
keewis
left a comment
There was a problem hiding this comment.
thanks for the fix, @spencerkclark. The docs should be fixed by indenting the whats-new.rst entry.
Co-authored-by: keewis <keewis@users.noreply.github.com>
Collaborator
|
thanks again, @spencerkclark. |
This was referenced Jul 5, 2021
4 tasks
2 tasks
5 tasks
glemieux
added a commit
to glemieux/fates
that referenced
this pull request
Apr 6, 2023
This incorporates an update to handle a pandas deprication issue when using cftime objects. See pydata/xarray#5359
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pandas recently deprecated the
kindargument inIndex._maybe_cast_slice_bound, and removed its use in several internal calls: pandas-dev/pandas#41378. This led to some errors in the CFTimeIndex tests in our upstream build. We never made use of it inCFTimeIndex._maybe_cast_slice_boundso the simplest fix for backwards compatibility seems to be to make it optional for now -- in previous versions of pandas it was required -- and remove it when our minimum version of pandas is at least 1.3.0.pre-commit run --all-fileswhats-new.rst