Option to skip allocation for empty cell. #464
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some excelx client (not sure which) creates a badly formatted file. I've attached one such file which when processed by roo will use a huge amount of memory.
Incase if you open & save such file in most of excelx client will fix the bad formated part (which can be observed with change in file size from ~5MB to ~37KB).
Since in production environment we can not add a constraint on excelx client used to generate the file, some badly formatted file will crash the server/process.
This changeset skips creation of empty cell and skips assignment of the key, value pair for such empty cell in the hash.
Benchmark result for the attached file.
Master:
After Patch:
Need to discuss following things before we can go ahead with this:
bad-formated-file.xlsx