-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add escape_strings
option to PrettyConfig
#426
Conversation
5add5bd
to
1a31674
Compare
Codecov ReportBase: 87.22% // Head: 86.73% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #426 +/- ##
==========================================
- Coverage 87.22% 86.73% -0.49%
==========================================
Files 58 59 +1
Lines 7145 7281 +136
==========================================
+ Hits 6232 6315 +83
- Misses 913 966 +53
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
These codecov results again make no sense. At some point I will need to investigate how to get them to be more stable, as on some weeks it works perfectly, and on some lines without code are marked as not covered :/ |
Though I did notice that I introduced three uncovered test lines in #424 ... |
?r @torkleyy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
1a31674
to
0cc3571
Compare
This PR adds an
escape_strings
option toPrettyConfig
that is enabled by default. When enabled, strings are serialised using escapes. When disabled, strings that contain no"
are serialised literally. If the string does contain a"
, a raw string literal with the minimum number of required leading#
is emitted.This feature was suggested in #425, i.e. this PR fixes #425.
CHANGELOG.md