Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #423 deserialising an identifier into a borrowed str #424

Merged
merged 1 commit into from
Oct 18, 2022
Merged

Fix #423 deserialising an identifier into a borrowed str #424

merged 1 commit into from
Oct 18, 2022

Conversation

juntyr
Copy link
Member

@juntyr juntyr commented Oct 18, 2022 •
edited
Loading

Fixes #423 by deserialising an identifier using visit_borrowed_str. This was probably never caught before since serge-derived code uses the less strict visit_str, but deserialising into a &str requires the borrowing.

  • I've included my change in CHANGELOG.md

@juntyr juntyr merged commit 27d2de4 into ron-rs:master Oct 18, 2022
@juntyr juntyr deleted the 423-de-borrowed-identifier branch October 18, 2022 08:21
@juntyr juntyr mentioned this pull request Oct 21, 2022
Merged
1 task
juntyr added a commit to juntyr/ron that referenced this pull request Aug 15, 2023
@juntyr
Fix ron-rs#423 deserialising an identifier into a borrowed str (ron-r…
368a861 
…s#424)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to deserialize a struct?
1 participant
@juntyr