fix: Make tar decompression only consider regular files #1260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `tar` decompression function was failing for some users, with error message: ``` 'NoneType' object does not support the context manager protocol ``` As explained in the official documentation [1], the `extractfile` method returns `None` if the member is not a regular file or a link. This change skips any member that is not a regular file. [1] https://docs.python.org/3/library/tarfile.html#tarfile.TarFile.extractfile
zurdi15
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
tardecompression function was failing for some users, with error message:As explained in the official documentation [1], the
extractfilemethod returnsNoneif the member is not a regular file or a link. This change skips any member that is not a regular file.[1] https://docs.python.org/3/library/tarfile.html#tarfile.TarFile.extractfile