Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] RomM gets stuck while triying to scan some roms (.7z extension related) #1211

Open
outerwinnie opened this issue Sep 24, 2024 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@outerwinnie
Copy link

RomM version
3.5.1

Describe the bug
It seems that if a rom have .7z extension and goes over certain size, RomM gets permanently stuck scanning that one rom.

To Reproduce
Steps to reproduce the behavior:

  1. Scan a rom file with .7z and over 4Gb (maybe 3Gb)
  2. See error

Expected behavior
It shouldn't get stuck there, and should identify the rom correctly as (i think) was pre 3.5.0

@outerwinnie outerwinnie added the bug Something isn't working label Sep 24, 2024
@gantoine
Copy link
Member

Can you post the scan logs?

@outerwinnie
Copy link
Author

Can you post the scan logs?

Sorry, I post it on Discord and forgot to post it here to, here it is:

`INFO:      [RomM][2024-09-21 20:45:38] Found 1 platforms in file system 
INFO:      [RomM][2024-09-21 20:45:38] · PC
20:45:37 high: endpoints.sockets.scan.scan_platforms([4], <ScanType.QUICK: 'quick'>, [], ['igdb']) (e29178f2-5a99-4d52-b92e-cb16e7eba171)
INFO:      [RomM][2024-09-21 20:45:37] 🔎 Scanning 
INFO:      [RomM][2024-09-21 20:45:39]   Identified as PC (Microsoft Windows) 🎮
WARNING:  [RomM][2024-09-21 20:45:39]   ⚠️ No firmware found, skipping firmware scan for this platform
INFO:      [RomM][2024-09-21 20:45:39]   22 roms found
INFO:      [RomM][2024-09-21 20:45:39]      · Silent Hill 3.7z
20:46:57 Moving job to FailedJobRegistry (Work-horse terminated unexpectedly; waitpid returned 9 (signal 9); )`

@rarrais
Copy link

rarrais commented Sep 25, 2024

I have a similar issue with version 3.5.1. In my case, it's trowing an error when dealing with platforms containing .tar.gz files. No issues in other platforms.

I can confirm that the error is not appearing when reverting to version 3.3.0.

romm  | 2024-09-25T17:01:44.658976093Z INFO:      [RomM][2024-09-25 18:01:44] · win
romm  | 2024-09-25T17:01:45.382788678Z INFO:      [RomM][2024-09-25 18:01:45]   Identified as PC (Microsoft Windows) 🎮
romm  | 2024-09-25T17:01:45.393398166Z WARNING:  [RomM][2024-09-25 18:01:45]   ⚠️ No firmware found, skipping firmware scan for this platform
romm  | 2024-09-25T17:01:45.427450166Z INFO:      [RomM][2024-09-25 18:01:45]   <REDACTED> roms found
romm  | 2024-09-25T17:01:45.442098113Z INFO:      [RomM][2024-09-25 18:01:45]    · <REDACTED>
romm  | 2024-09-25T17:01:45.442130533Z INFO:      [RomM][2024-09-25 18:01:45]            · <REDACTED>.tar.gz
romm  | 2024-09-25T17:02:00.363459489Z ERROR:     [RomM][2024-09-25 18:02:00] 'NoneType' object does not support the context manager protocol

@adamantike adamantike self-assigned this Oct 6, 2024
adamantike added a commit that referenced this issue Oct 6, 2024
This change improves memory usage, by only keeping a single archive's
member file in memory at a time during 7zip decompression.

The `py7zr` library does not support streaming decompression yet, so
this change is the best we can do for now.

Potential fix for #1211, but it won't improve memory usage for
single-file 7zip archives.
@adamantike
Copy link
Collaborator

@rarrais, the issue with .tar.gz files is a different one, but we were able to come up with a fix for it in #1260.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants