fix(rome_lsp): rename off by default for vscode

crates/rome_lsp/Cargo.toml

@@ -23,7 +23,7 @@ rome_flags = { path = "../rome_flags" }
 rome_rowan = { path = "../rome_rowan" }
 rome_console = { path = "../rome_console" }
 rome_text_edit = { path = "../rome_text_edit" }
-tokio = { workspace = true, features = ["io-std"] }
+tokio = { workspace = true, features = ["rt", "io-std"] }
 tower-lsp = { version = "0.17.0" }
 tracing = { workspace = true, features = ["attributes"] }
 futures = "0.3"

crates/rome_lsp/src/config.rs

@@ -11,11 +11,14 @@ pub struct WorkspaceSettings {
     /// Unstable features enabled
     #[serde(default)]
     pub unstable: bool,
+
+    /// Enable rename capability
+    pub rename: Option<bool>,
 }
 
 #[derive(Debug)]
 pub(crate) struct Config {
-    settings: WorkspaceSettings,
+    pub(crate) settings: WorkspaceSettings,
 }
 
 impl Config {

crates/rome_lsp/src/server.rs

@@ -167,6 +167,30 @@ impl LanguageServer for LSPServer {
         Ok(())
     }
 
+    #[tracing::instrument(level = "trace", skip(self))]
+    async fn did_change_configuration(&self, params: DidChangeConfigurationParams) {
+        let _ = params;
+        self.session.fetch_client_configuration().await;
+    }
+
+    async fn did_open(&self, params: DidOpenTextDocumentParams) {
+        handlers::text_document::did_open(&self.session, params)
+            .await
+            .ok();
+    }
+
+    async fn did_change(&self, params: DidChangeTextDocumentParams) {
+        handlers::text_document::did_change(&self.session, params)
+            .await
+            .ok();
+    }
+
+    async fn did_close(&self, params: DidCloseTextDocumentParams) {
+        handlers::text_document::did_close(&self.session, params)
+            .await
+            .ok();
+    }
+
     async fn code_action(&self, params: CodeActionParams) -> LspResult<Option<CodeActionResponse>> {
         handlers::analysis::code_actions(&self.session, params).map_err(into_lsp_error)
     }
@@ -192,32 +216,20 @@ impl LanguageServer for LSPServer {
         handlers::formatting::format_on_type(&self.session, params).map_err(into_lsp_error)
     }
 
-    #[tracing::instrument(level = "trace", skip(self))]
-    async fn did_change_configuration(&self, params: DidChangeConfigurationParams) {
-        let _ = params;
-        self.session.fetch_client_configuration().await;
-    }
-
-    async fn did_open(&self, params: DidOpenTextDocumentParams) {
-        handlers::text_document::did_open(&self.session, params)
-            .await
-            .ok();
-    }
-
-    async fn did_change(&self, params: DidChangeTextDocumentParams) {
-        handlers::text_document::did_change(&self.session, params)
-            .await
-            .ok();
-    }
-
-    async fn did_close(&self, params: DidCloseTextDocumentParams) {
-        handlers::text_document::did_close(&self.session, params)
-            .await
-            .ok();
-    }
-
     async fn rename(&self, params: RenameParams) -> LspResult<Option<WorkspaceEdit>> {
-        handlers::rename::rename(&self.session, params).map_err(into_lsp_error)
+        let rename_enabled = self
+            .session
+            .config
+            .read()
+            .ok()
+            .and_then(|config| config.settings.rename)
+            .unwrap_or(false);
+
+        if rename_enabled {
+            handlers::rename::rename(&self.session, params).map_err(into_lsp_error)
+        } else {
+            Ok(None)
+        }
     }
 }
 

editors/vscode/package.json

@@ -82,6 +82,14 @@
 					],
 					"default": null,
 					"markdownDescription": "The rome lsp server executable. If the path is relative, the workspace folder will be used as base path"
+				},
+				"rome.rename": {
+					"type": [
+						"boolean",
+						"null"
+					],
+					"default": null,
+					"markdownDescription": "Enable/Disable Rome handling renames in the workspace. (Experimental)"
 				}
 			}
 		},
@@ -107,7 +115,7 @@
 		"watch": "npm run compile -- --sourcemap --watch",
 		"package": "vsce package -o rome_lsp.vsix",
 		"build": "npm run compile -- --minify && npm run package",
-		"install-extension": "code --install-extension rome_lsp.vsix",
+		"install-extension": "code --install-extension rome_lsp.vsix --force",
 		"format": "cargo run --bin rome format ./src/ ./scripts --write",
 		"pack:dev": "npm run compile && npm run package && npm run install-extension",
 		"tsc": "tsc"

editors/vscode/src/main.ts

@@ -31,6 +31,12 @@ export async function activate(context: ExtensionContext) {
 	const command =
 		process.env.DEBUG_SERVER_PATH || (await getServerPath(context));
 
+	if (process.env.DEBUG_SERVER_PATH) {
+		window.showInformationMessage(
+			`Rome DEBUG_SERVER_PATH detected: ${command}`,
+		);
+	}
+
 	if (!command) {
 		await window.showErrorMessage(
 			"The Rome extensions doesn't ship with prebuilt binaries for your platform yet. " +