This repository was archived by the owner on Aug 31, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 657
fix(rome_lsp): rename off by default for vscode #3473
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rometools canceled.
|
xunilrj
commented
Oct 21, 2022
@@ -23,7 +23,7 @@ rome_flags = { path = "../rome_flags" } | |||
rome_rowan = { path = "../rome_rowan" } | |||
rome_console = { path = "../rome_console" } | |||
rome_text_edit = { path = "../rome_text_edit" } | |||
tokio = { workspace = true, features = ["io-std"] } | |||
tokio = { workspace = true, features = ["rt", "io-std"] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rome_lsp
was not compiling
xunilrj
commented
Oct 21, 2022
@@ -167,6 +167,30 @@ impl LanguageServer for LSPServer { | |||
Ok(()) | |||
} | |||
|
|||
#[tracing::instrument(level = "trace", skip(self))] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just sorted these fns.
leops
reviewed
Oct 24, 2022
ematipico
suggested changes
Oct 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please do some testing on the extension itself? By looking at your test plan, it seems that hasn't bee done
Done. |
ematipico
approved these changes
Oct 25, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR sets renaming as off by default.
I have not found a way to change Server capability inside
did_configuration_changed
, so I decided to register the LSP server capable of renaming, but forfeiting the request when the config isnull
orfalse
.I am also notifying the user when
vscode
starts and the debug environment variable is being used.Test Plan
on Windows
Open a JS/TS file. We will see:
Which means the
rename
config is defaulting tonull
yet.Later we see:
If we rename a variable now, no
rename
request will be seen.If we change the variable to
true
. We will see :Now if we rename a variable we see the
rename
request