Skip to content

Conversation

AG-Labs
Copy link

@AG-Labs AG-Labs commented Sep 19, 2025

Description of the change

This PR fixes issue introduced where turning on session replay has added logs of most rollbar actions to the console.

It wraps the offending console.log in an if statement depending on the logEmits property. It may well be that this is not the intended configuration option for this so let me know and I can update. I have also not provided a fallback value for options and passed it down where required as that is what seems to be done elsewhere I can change this If desired.

I have also noticed that some of the docs relating to the tests are out of date since this PR so have updated these. #1303

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Checklists

Development

  • Lint rules pass locally. the same 4 warnings as appear on master are on my branch
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant