-
Notifications
You must be signed in to change notification settings - Fork 212
[Meta-branch] Karma -> WTR migration and Grunt removal #1303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates the project from Karma test runner to Web Test Runner (WTR) with Playwright and removes Grunt as a build tool. The migration modernizes the testing infrastructure for better performance and maintainability while maintaining test functionality.
- Migration from Karma to Web Test Runner with Playwright for browser testing
- Replacement of Grunt build system with npm scripts
- Update of test assertion syntax from Chai 4 to Chai 5 style
Reviewed Changes
Copilot reviewed 58 out of 59 changed files in this pull request and generated 11 comments.
Show a summary per file
File | Description |
---|---|
web-test-runner.config.mjs | New WTR configuration with Playwright launcher and test framework settings |
package.json | Removed Karma/Grunt dependencies, added WTR packages, updated npm scripts |
test/**/*.test.js | Updated test files with ES6 imports and Chai 5 assertion syntax |
test/util/*.js | New utility modules for timers and fixture loading in WTR environment |
karma.conf.cjs | Removed Karma configuration file |
Gruntfile.cjs | Removed Grunt build configuration |
Comments suppressed due to low confidence (1)
test/browser.rollbar.test.js:1
- The test expects an array to be converted to an object with numeric keys, but the test description and variable name suggest it should remain an array. This inconsistency could indicate a bug in either the test or the implementation.
import { expect } from 'chai';
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Description of the change
This branch consolidates the following approved PRs:
SDK-493/replace-karma-with-webtest-runner-for-modern-performant-browser