Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rollbar::JSON #321

Merged
merged 5 commits into from
Oct 19, 2015
Merged

Fix Rollbar::JSON #321

merged 5 commits into from
Oct 19, 2015

Commits on Oct 8, 2015

  1. Fix when MultiJson is using adapters other than Oj

    Whenever Yajl is used for MultiJson, before this patch,
    Rollbar would find ::Yajl instead of Rollbar::JSON::Yajl,
    and ::Yajl does exist but it does not respond to `options`,
    causing failures.
    
    It's surprising that Rollbar::JSON.const_get(:Yajl) would
    find ::Yajl instead, it's like using Rollbar::JSON::Yajl to
    refer to ::Yajl, this is really unfortunate for Ruby.
    But given current status, we cannot rely on const_get in
    this case. Therefore we'll need to search on constants
    instead.
    
    This has another advantage -- we no longer need to rescue,
    saving an exception.
    godfat committed Oct 8, 2015
    Configuration menu
    Copy the full SHA
    27cd201 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9cb0f10 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2015

  1. Merge remote-tracking branch 'refs/remotes/origin/master' into fix/js…

    …on-const-get
    Jon de Andres committed Oct 16, 2015
    Configuration menu
    Copy the full SHA
    09242e8 View commit details
    Browse the repository at this point in the history
  2. Use const_defined? and const_get correctly in Rollbar::JSON

    Passing inherit = false we ensure we only find constants in the passed module.
    Jon de Andres committed Oct 16, 2015
    Configuration menu
    Copy the full SHA
    1c02650 View commit details
    Browse the repository at this point in the history
  3. Fix Rollbar::JSON for Ruby 1.8

    Jon de Andres committed Oct 16, 2015
    Configuration menu
    Copy the full SHA
    8339a49 View commit details
    Browse the repository at this point in the history