Fix Rollbar::JSON #321
Merged
Fix Rollbar::JSON #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whenever Yajl is used for MultiJson, before this patch, Rollbar would find ::Yajl instead of Rollbar::JSON::Yajl, and ::Yajl does exist but it does not respond to `options`, causing failures. It's surprising that Rollbar::JSON.const_get(:Yajl) would find ::Yajl instead, it's like using Rollbar::JSON::Yajl to refer to ::Yajl, this is really unfortunate for Ruby. But given current status, we cannot rely on const_get in this case. Therefore we'll need to search on constants instead. This has another advantage -- we no longer need to rescue, saving an exception.
Passing inherit = false we ensure we only find constants in the passed module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.