Major refactoring and modularization of the ros-mcp server #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release/v2.2.1
Previously, compressed images were saved to `./camera/received_image_compressed.jpeg` while raw images were saved to `./camera/received_image.jpeg`. This caused the `analyze_previously_received_image` tool to fail when trying to analyze compressed images, as it only looks for `./camera/received_image.jpeg`. This commit standardizes the path for both compressed and raw images to use `./camera/received_image.jpeg`, ensuring that the analysis tool can find images regardless of their original format.
Hotfix: use consistent image path for compressed and raw images
- Add plans.md: Index document for all planning documents - Add restructuring_plan.md: Complete implementation guide with split-by-feature structure - Update merge_plan.md: High-level overview with structure options - Update move_all_tools.md: Quick reference guide for tool migration
- Move merge_plan.md, move_all_tools.md, restructuring_plan.md to docs/ - Add plans.md index document in docs/ - Update references to simple-mcp-ai in merge_plan.md
- Updated restructuring_plan.md to reflect package structure using __init__.py - Changed tools.py references to tools/__init__.py - Documented utils/__init__.py structure - Updated pyproject.toml: removed py-modules, added proper packages configuration - Restructured codebase to use package structure with __init__.py files
* Add MCP resources for ROS metadata and robot specs - Add resources/ros_metadata.py: Resource for getting all ROS metadata (topics, services, nodes, parameters) - Add resources/robot_specs.py: Resource for listing all available robot specifications - Fix rosapi parameters service: Use /rosapi/get_param_names instead of /rosapi/parameters - Add resources/__init__.py: Register all resources with MCP server - Update server.py: Register MCP resources on startup
- Create ros_mcp/tools/services.py with service-related tools - Create ros_mcp/tools/nodes.py with node-related tools - Update restructuring plan documentation with progress - Update tools_plan.md with migration status - Update tool registration in __init__.py
…logic, and format code
- Tools migrated: get_parameter, set_parameter, has_parameter, delete_parameter, get_parameters, inspect_all_parameters, get_parameter_details
- Update server.py to use ros_mcp.main instead of ros_mcp.server - Remove server_monolithic.py (functionality fully migrated to modular structure) - All functionality now consolidated in ros_mcp/main.py + server.py
- Fix tool count from 38 to 39 by restoring get_topic_publishers and get_topic_subscribers - Add get_topic_publishers_impl and get_topic_subscribers_impl functions - Remove get_topic_details tool registration (was not in original 39 tools) - Update resource imports to use ros_mcp.utils.websocket_manager - Fix robot_specs.py path calculation for new location
… utils folder - Rename ros_mcp/utils/websocket_manager.py to websocket.py - Update all imports across codebase to use new module name - Remove base utils/ folder (all functions migrated to ros_mcp/utils/) - Consolidate utils structure to single location
Fixed incorrect path resolution for robot_specifications directory. Changed from parent.parent to parent.parent.parent to correctly point to project root where robot_specifications/ is located.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.