Skip to content

fix: openai parameterization errors #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: openai parameterization errors #152

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions org-ai-openai.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -715,12 +715,12 @@ is the presence penalty.

;; o1 models currently does not support system prompt
(when (and (or (eq service 'openai) (eq service 'azure-openai))
(or (string-prefix-p "o1" model) (string-prefix-p "o3" model)))
(string-prefix-p "o" model))
(setq messages (cl-remove-if (lambda (msg) (string-equal (plist-get msg :role) "system")) messages))
;; o1 does not support max-tokens
(when max-tokens
(setq max-tokens nil)
(setq max-completion-tokens (or max-tokens 128000))))
(setq max-completion-tokens (or max-tokens 128000))
(setq max-tokens nil)))

(let* ((input (if messages `(messages . ,messages) `(prompt . ,prompt)))
;; TODO yet unsupported properties: n, stop, logit_bias, user
Expand All @@ -729,7 +729,7 @@ is the presence penalty.
(model . ,model)
,@(when stream `((stream . ,stream)))
,@(when max-tokens `((max_tokens . ,max-tokens)))
,@(when max-completion-tokens `((max-completion-tokens . ,max-completion-tokens)))
,@(when max-completion-tokens `((max_completion_tokens . ,max-completion-tokens)))
,@(when temperature `((temperature . ,temperature)))
,@(when top-p `((top_p . ,top-p)))
,@(when frequency-penalty `((frequency_penalty . ,frequency-penalty)))
Expand Down