fix: openai parameterization errors #152
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use value of max-tokens before setting it to nil, rather than the other way around. Replace `max-completion-tokens' with `max_completion_tokens` in parameters to openai API. Expand use of `max_completion_tokens' parameter to all o-series models, rather than merely o1 and o3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use value of max-tokens before setting it to nil, rather than the other way around.
Replace
max-completion-tokens' withmax_completion_tokens` in parameters to openai API.Expand use of `max_completion_tokens' parameter to all o-series models, rather than merely o1 and o3.
These are the minimal changes to fix the openai module. More broadly, it looks like
max_tokenshas been deprecated in favor ofmax_completion_tokensaccording to the API docs. Maybe the whole section needs a bit of a rewrite if this is in fact the case?