Adding properties should work when additionalProperties is true
#3181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changes in v5 caused a regression where `additionalProperties: true` was not properly evaluated. - Change ObjectField logic to handle that case. - Add tests to validate the logic in handleAddClick, including the regression
nickgros
commented
Oct 5, 2022
heath-freenome
approved these changes
Oct 5, 2022
nickgros
commented
Oct 5, 2022
Co-authored-by: Heath C <51679588+heath-freenome@users.noreply.github.com>
|
Why didn’t you just restart it manually?
…On Wed, Oct 5, 2022 at 1:15 PM Nick Grosenbacher ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In CHANGELOG.md
<#3181 (comment)>
:
> @@ -21,7 +21,8 @@ should change the heading of the (upcoming) version to include a major version b
- Added support for `chakra-react-select` v4, fixing [#3152](#3152).
## @rjsf/core
-- Extended `Form.onChange` to optionally return the `id` of the field that caused the change, fixing (#2768)
+- Extended `Form.onChange` to optionally return the `id` of the field that caused the change, fixing [#2768](#2768)
Should have just added a blank commit to start the CI pipeline...thanks
for catching!
—
Reply to this email directly, view it on GitHub
<#3181 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMKJCZF2XIRYNJXSY7LU7I3WBXOV5ANCNFSM6AAAAAAQ5WNSOA>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
--
This e-mail is private and confidential and is for the addressee only. If
misdirected, please notify us by telephone, confirming that it has been
deleted from your system and any hard copies destroyed. You are strictly
prohibited from using, printing, distributing or disseminating it or any
information contained in it save to the intended recipient.
|
|
@heath-freenome Actions went down so it never created a job to restart, so I couldn't figure out how to do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3179
Conversion of ObjectField to TypeScript caused a regression where
additionalProperties: truewas not properly evaluated when adding a property.additionalProperties: true.