Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking add button when additionalProperties: true doesn't create a new property #3179

Closed
4 tasks done
nickgros opened this issue Oct 5, 2022 · 0 comments · Fixed by #3181
Closed
4 tasks done

Clicking add button when additionalProperties: true doesn't create a new property #3179

nickgros opened this issue Oct 5, 2022 · 0 comments · Fixed by #3181
Labels
bug needs triage Initial label given, to be assigned correct labels and assigned

Comments

@nickgros
Copy link
Contributor

nickgros commented Oct 5, 2022

Prerequisites

What theme are you using?

core

Version

5.0.0-beta.10

Current Behavior

When additionalProperties: true, clicking the add button does not add a property.

I think this may be a regression from v4.

Expected Behavior

Clicking the button adds a property.

If it doesn't make sense to add a property, e.g. because there is no sensible default type, then the add button should not be shown, and a breaking change warning should be added to the v5.

Steps To Reproduce

Link to playground reproduction

Environment

Playground 5.0.0-beta.10

Anything else?

No response

@nickgros nickgros added bug needs triage Initial label given, to be assigned correct labels and assigned labels Oct 5, 2022
@nickgros nickgros changed the title Adding a property when additionalProperties: true doesn't create a new property Clicking add button when additionalProperties: true doesn't create a new property Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug needs triage Initial label given, to be assigned correct labels and assigned
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant