-
-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix search range notation in search herald #4871
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fully agree on this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, pressed the button too quickly again. Can you please add this to the struct doxygen (in a more readable manner with \brief
and all)? This is where people will look first.
This should be explained in the book |
Ok 51ef7eb |
I have looked at the book and noticed that
|
This is on the list. Once the PR is reviewed and done I will rewrite the whole chapter. Also covering edge cases and such.
Also let's wait for refactor. Since it takes regex now. |
* Fix search range notation in search herald * Add doxygen to RzInterval
Your checklist for this pull request
RZ_API
function and struct this PR changes.RZ_API
).Detailed description
From the definition of
rz_itv_end()
:rizin/librz/include/rz_util/rz_itv.h
Lines 42 to 44 in 2c1a07d
the address returned by it is one byte beyond the interval and so this pr changes the range notation used in the search herald to reflect that.
Test plan
All builds are green.
Closing issues
...