Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix search range notation in search herald #4871

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

kazarmy
Copy link
Member

@kazarmy kazarmy commented Jan 31, 2025

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository.
  • I made sure to follow the project's coding style.
  • I've documented every RZ_API function and struct this PR changes.
  • I've added tests that prove my changes are effective (required for changes to RZ_API).
  • I've updated the Rizin book with the relevant information (if needed).

Detailed description

From the definition of rz_itv_end():

static inline ut64 rz_itv_end(RzInterval itv) {
return itv.addr + itv.size;
}

the address returned by it is one byte beyond the interval and so this pr changes the range notation used in the search herald to reflect that.

Test plan

All builds are green.

Closing issues

...

Copy link
Member

@wargio wargio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fully agree on this

Copy link
Member

@Rot127 Rot127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, pressed the button too quickly again. Can you please add this to the struct doxygen (in a more readable manner with \brief and all)? This is where people will look first.

@wargio
Copy link
Member

wargio commented Jan 31, 2025

This should be explained in the book

@github-actions github-actions bot added the API label Jan 31, 2025
@kazarmy
Copy link
Member Author

kazarmy commented Jan 31, 2025

Can you please add this to the struct doxygen ...

Ok 51ef7eb

@kazarmy
Copy link
Member Author

kazarmy commented Jan 31, 2025

This should be explained in the book

I have looked at the book and noticed that

  1. The search hits as currently presented could be better.
  2. There can be inconsistencies between / lib and /e /lib/ 🤦.

@Rot127
Copy link
Member

Rot127 commented Jan 31, 2025

The search hits as currently presented could be better.

This is on the list. Once the PR is reviewed and done I will rewrite the whole chapter. Also covering edge cases and such.

There can be inconsistencies between / lib and /e /lib/

Also let's wait for refactor. Since it takes regex now.

@kazarmy kazarmy merged commit 1b136ad into rizinorg:dev Jan 31, 2025
46 checks passed
tushar3q34 pushed a commit to tushar3q34/rizin that referenced this pull request Feb 2, 2025
* Fix search range notation in search herald
* Add doxygen to RzInterval
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants