Skip to content

ISA string issues with new Zdinx tests #649

@jordancarlin

Description

@jordancarlin

The new Zdinx fma tests added by #642 have incorrect RVTEST_ISA and RVTEST_CASE strings, which causes riscof to break.

Some of the tests (like fmadd.d_b1-01.S) have the correct RVTEST_ISA macro ("RV32I_Zfinx_Zdinx"), but the incorrect RVTEST_CASE macro ("//check ISA:=regex(.*I.*D.*)). This should be checking for Zdinx, not D.

Others have both macros wrong. For example, fmadd.d_b8-01.S has RVTEST_ISA("RV32IFD_Zicsr,RV64IFD_Zicsr") and RVTEST_CASE(0,"//check ISA:=regex(.*I.*D.*);def TEST_CASE_1=True;",fmadd.d_b8). Both of these should have Zdinx, not F/D.

These issues result in repeated warnings when compiling and cause riscof to fail:

/home/jcarlin/cvw-new/addins/riscv-arch-test/riscv-test-suite/rv32i_m/D/src/fmadd.d_b15/fmadd.d_b15-007.S: Assembler messages:
/home/jcarlin/cvw-new/addins/riscv-arch-test/riscv-test-suite/rv32i_m/D/src/fmadd.d_b15/fmadd.d_b15-007.S:5432: Warning: bignum truncated to 8 bytes
/home/jcarlin/cvw-new/addins/riscv-arch-test/riscv-test-suite/rv32i_m/D/src/fmadd.d_b15/fmadd.d_b15-007.S:5433: Warning: bignum truncated to 8 bytes
/home/jcarlin/cvw-new/addins/riscv-arch-test/riscv-test-suite/rv32i_m/D/src/fmadd.d_b15/fmadd.d_b15-007.S:5434: Warning: bignum truncated to 8 bytes
/home/jcarlin/cvw-new/addins/riscv-arch-test/riscv-test-suite/rv32i_m/D/src/fmadd.d_b15/fmadd.d_b15-007.S:5435: Warning: bignum truncated to 8 bytes
/home/jcarlin/cvw-new/addins/riscv-arch-test/riscv-test-suite/rv32i_m/D/src/fmadd.d_b15/fmadd.d_b15-007.S:5436: Warning: bignum truncated to 8 bytes
/home/jcarlin/cvw-new/addins/riscv-arch-test/riscv-test-suite/rv32i_m/D/src/fmadd.d_b15/fmadd.d_b15-007.S:5437: Warning: bignum truncated to 8 bytes
/home/jcarlin/cvw-new/addins/riscv-arch-test/riscv-test-suite/rv32i_m/D/src/fmadd.d_b15/fmadd.d_b15-007.S:5438: Warning: bignum truncated to 8 bytes
/home/jcarlin/cvw-new/addins/riscv-arch-test/riscv-test-suite/rv32i_m/D/src/fmadd.d_b15/fmadd.d_b15-007.S:5439: Warning: bignum truncated to 8 bytes
/home/jcarlin/cvw-new/addins/riscv-arch-test/riscv-test-suite/rv32i_m/D/src/fmadd.d_b15/fmadd.d_b15-007.S:5440: Warning: bignum truncated to 8 bytes
/home/jcarlin/cvw-new/addins/riscv-arch-test/riscv-test-suite/rv32i_m/D/src/fmadd.d_b15/fmadd.d_b15-007.S:5441: Warning: bignum truncated to 8 bytes

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions