Merge new 404 design into main #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed header and footer background color for both light and dark modes
The headings should no longer be underlined and cards should now show have black as font color in dark mode
The links and titles should now show properly in cards for both dark and light modes
This commit includes multiple changes for the rebranding styles, like changing some colors. * The right content bar should now be sticky to the page, making it always available with no need to scroll to the top * Collapse and Expand all buttons has been added for the left navbar * The GCX code component should now take all the entire height from the body space on the website. * The code blocks should no longer have bold font
This commit includes the new content and style applied to the antora 404 page.
This update includes the relative paths used on the live server
Changed location to /en/home
The footer for the 404 page should now be fixed at the bottom of the device
Testing permissions
Fixed relative paths on 404 page
johnsmartco
approved these changes
Feb 23, 2023
KenniMartinezM
added a commit
that referenced
this pull request
Mar 29, 2023
* Merge new 404 design into main (#57) * Initial rebranding styles Changed header and footer background color for both light and dark modes * Initial rebranding styles * Fixing styles The headings should no longer be underlined and cards should now show have black as font color in dark mode * Fixes in links The links and titles should now show properly in cards for both dark and light modes * Rebranding styles This commit includes multiple changes for the rebranding styles, like changing some colors. * The right content bar should now be sticky to the page, making it always available with no need to scroll to the top * Collapse and Expand all buttons has been added for the left navbar * The GCX code component should now take all the entire height from the body space on the website. * The code blocks should no longer have bold font * New 404 docs design This commit includes the new content and style applied to the antora 404 page. * Update 404.hbs This update includes the relative paths used on the live server * Update 404.hbs Changed location to /en/home * 404 footer fix The footer for the 404 page should now be fixed at the bottom of the device * 404 Fixes Fixed 404 design for mobile and error on console fixed * Update 404.hbs Testing permissions * Update 404.hbs Fixed relative paths on 404 page --------- Co-authored-by: Kenni Martínez <57879404+KenniM@users.noreply.github.com> * Fix 404 encoding (#61) * Initial rebranding styles Changed header and footer background color for both light and dark modes * Initial rebranding styles * Fixing styles The headings should no longer be underlined and cards should now show have black as font color in dark mode * Fixes in links The links and titles should now show properly in cards for both dark and light modes * Rebranding styles This commit includes multiple changes for the rebranding styles, like changing some colors. * The right content bar should now be sticky to the page, making it always available with no need to scroll to the top * Collapse and Expand all buttons has been added for the left navbar * The GCX code component should now take all the entire height from the body space on the website. * The code blocks should no longer have bold font * New 404 docs design This commit includes the new content and style applied to the antora 404 page. * Update 404.hbs This update includes the relative paths used on the live server * Update 404.hbs Changed location to /en/home * 404 footer fix The footer for the 404 page should now be fixed at the bottom of the device * 404 Fixes Fixed 404 design for mobile and error on console fixed * Update 404.hbs Testing permissions * Update 404.hbs Fixed relative paths on 404 page * Updated 404.hbs This should fix the encoding for this page. * Change L88 to use single plain quote in the word can't --------- Co-authored-by: Kenni Martínez <57879404+KenniM@users.noreply.github.com> Co-authored-by: John Smart <johnsmartnh@gmail.com> * Left Nav Improvements (#65) This should fix a visual issue when using some new types of nav elements Co-authored-by: Kenni Martínez <57879404+KenniM@users.noreply.github.com> * Update README.adoc * Update README.adoc --------- Co-authored-by: Kenni Martínez <57879404+KenniM@users.noreply.github.com> Co-authored-by: John Smart <johnsmartnh@gmail.com> Co-authored-by: Eric Schneider <37347760+eric-schneider@users.noreply.github.com>
johnsmartco
added a commit
that referenced
this pull request
Apr 25, 2023
* Dependabot issues tested * Updating dependabot-test from main (#58) * Merge New 404 design into Main (#48) * Initial rebranding styles Changed header and footer background color for both light and dark modes * Initial rebranding styles * Fixing styles The headings should no longer be underlined and cards should now show have black as font color in dark mode * Fixes in links The links and titles should now show properly in cards for both dark and light modes * Rebranding styles This commit includes multiple changes for the rebranding styles, like changing some colors. * The right content bar should now be sticky to the page, making it always available with no need to scroll to the top * Collapse and Expand all buttons has been added for the left navbar * The GCX code component should now take all the entire height from the body space on the website. * The code blocks should no longer have bold font * New 404 docs design This commit includes the new content and style applied to the antora 404 page. * Update 404.hbs This update includes the relative paths used on the live server * Update 404.hbs Changed location to /en/home * 404 footer fix The footer for the 404 page should now be fixed at the bottom of the device * Dependabot issues tested (#50) --------- Co-authored-by: Kenni Martínez <57879404+KenniM@users.noreply.github.com> * Dependabot issues * Updating branch to check new Dependabot issues (#66) * Merge new 404 design into main (#57) * Initial rebranding styles Changed header and footer background color for both light and dark modes * Initial rebranding styles * Fixing styles The headings should no longer be underlined and cards should now show have black as font color in dark mode * Fixes in links The links and titles should now show properly in cards for both dark and light modes * Rebranding styles This commit includes multiple changes for the rebranding styles, like changing some colors. * The right content bar should now be sticky to the page, making it always available with no need to scroll to the top * Collapse and Expand all buttons has been added for the left navbar * The GCX code component should now take all the entire height from the body space on the website. * The code blocks should no longer have bold font * New 404 docs design This commit includes the new content and style applied to the antora 404 page. * Update 404.hbs This update includes the relative paths used on the live server * Update 404.hbs Changed location to /en/home * 404 footer fix The footer for the 404 page should now be fixed at the bottom of the device * 404 Fixes Fixed 404 design for mobile and error on console fixed * Update 404.hbs Testing permissions * Update 404.hbs Fixed relative paths on 404 page --------- Co-authored-by: Kenni Martínez <57879404+KenniM@users.noreply.github.com> * Fix 404 encoding (#61) * Initial rebranding styles Changed header and footer background color for both light and dark modes * Initial rebranding styles * Fixing styles The headings should no longer be underlined and cards should now show have black as font color in dark mode * Fixes in links The links and titles should now show properly in cards for both dark and light modes * Rebranding styles This commit includes multiple changes for the rebranding styles, like changing some colors. * The right content bar should now be sticky to the page, making it always available with no need to scroll to the top * Collapse and Expand all buttons has been added for the left navbar * The GCX code component should now take all the entire height from the body space on the website. * The code blocks should no longer have bold font * New 404 docs design This commit includes the new content and style applied to the antora 404 page. * Update 404.hbs This update includes the relative paths used on the live server * Update 404.hbs Changed location to /en/home * 404 footer fix The footer for the 404 page should now be fixed at the bottom of the device * 404 Fixes Fixed 404 design for mobile and error on console fixed * Update 404.hbs Testing permissions * Update 404.hbs Fixed relative paths on 404 page * Updated 404.hbs This should fix the encoding for this page. * Change L88 to use single plain quote in the word can't --------- Co-authored-by: Kenni Martínez <57879404+KenniM@users.noreply.github.com> Co-authored-by: John Smart <johnsmartnh@gmail.com> * Left Nav Improvements (#65) This should fix a visual issue when using some new types of nav elements Co-authored-by: Kenni Martínez <57879404+KenniM@users.noreply.github.com> * Update README.adoc * Update README.adoc --------- Co-authored-by: Kenni Martínez <57879404+KenniM@users.noreply.github.com> Co-authored-by: John Smart <johnsmartnh@gmail.com> Co-authored-by: Eric Schneider <37347760+eric-schneider@users.noreply.github.com> * Dependabot issues Since the last check, only two new issues has been generated and tested. The build was generated with no problems --------- Co-authored-by: Kenni Martínez <57879404+KenniM@users.noreply.github.com> Co-authored-by: John Smart <johnsmartnh@gmail.com> Co-authored-by: Eric Schneider <37347760+eric-schneider@users.noreply.github.com> Co-authored-by: Josué Bran <josuebran@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the fixes for the 404 page that now it shows correctly the web page on mobile. Also a console error has been fixed.