Skip to content

Conversation

KenniM
Copy link
Contributor

@KenniM KenniM commented Feb 10, 2023

  • Most of the issues belongs to stencil components, mostly associated with testing
  • A build with the newer versions was made, no issues found.
  • Since the packages problems belongs to a library used in testing, the GCX components were not affected

@johnsmartco johnsmartco self-assigned this Feb 14, 2023
@johnsmartco johnsmartco added the enhancement New feature or request label Feb 14, 2023
@johnsmartco johnsmartco added this to the Ready for review milestone Feb 14, 2023
@johnsmartco johnsmartco self-requested a review February 14, 2023 18:46
Copy link
Contributor

@johnsmartco johnsmartco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests of the newly built ui-bundle.zip with temporary branches of riptano/astra-docs and datastax/dev-app-drivers all looked fine. Approving.

@johnsmartco johnsmartco merged commit 002e9cd into main Feb 14, 2023
KenniMartinezM added a commit that referenced this pull request Feb 23, 2023
* Merge New 404 design into Main (#48)

* Initial rebranding styles

Changed header and footer background color for both light and dark modes

* Initial rebranding styles

* Fixing styles

The headings should no longer be underlined and cards should now show have black as font color in dark mode

* Fixes in links

The links and titles should now show properly in cards for both dark and light modes

* Rebranding styles

This commit includes multiple changes for the rebranding styles, like changing some colors.
* The right content bar should now be sticky to the page, making it always available with no need to scroll to the top
* Collapse and Expand all buttons has been added for the left navbar
* The GCX code component should now take all the entire height from the body space on the  website.
* The code blocks should no longer have bold font

* New 404 docs design

This commit includes the new content and style applied to the antora 404 page.

* Update 404.hbs

This update includes the relative paths used on the live server

* Update 404.hbs

Changed location to /en/home

* 404 footer fix

The footer for the 404 page should now be fixed at the bottom of the device

* Dependabot issues tested (#50)

---------

Co-authored-by: Kenni Martínez <57879404+KenniM@users.noreply.github.com>
johnsmartco added a commit that referenced this pull request Apr 25, 2023
* Dependabot issues tested

* Updating dependabot-test from main (#58)

* Merge New 404 design into Main (#48)

* Initial rebranding styles

Changed header and footer background color for both light and dark modes

* Initial rebranding styles

* Fixing styles

The headings should no longer be underlined and cards should now show have black as font color in dark mode

* Fixes in links

The links and titles should now show properly in cards for both dark and light modes

* Rebranding styles

This commit includes multiple changes for the rebranding styles, like changing some colors.
* The right content bar should now be sticky to the page, making it always available with no need to scroll to the top
* Collapse and Expand all buttons has been added for the left navbar
* The GCX code component should now take all the entire height from the body space on the  website.
* The code blocks should no longer have bold font

* New 404 docs design

This commit includes the new content and style applied to the antora 404 page.

* Update 404.hbs

This update includes the relative paths used on the live server

* Update 404.hbs

Changed location to /en/home

* 404 footer fix

The footer for the 404 page should now be fixed at the bottom of the device

* Dependabot issues tested (#50)

---------

Co-authored-by: Kenni Martínez <57879404+KenniM@users.noreply.github.com>

* Dependabot issues

* Updating branch to check new Dependabot issues (#66)

* Merge new 404 design into main (#57)

* Initial rebranding styles

Changed header and footer background color for both light and dark modes

* Initial rebranding styles

* Fixing styles

The headings should no longer be underlined and cards should now show have black as font color in dark mode

* Fixes in links

The links and titles should now show properly in cards for both dark and light modes

* Rebranding styles

This commit includes multiple changes for the rebranding styles, like changing some colors.
* The right content bar should now be sticky to the page, making it always available with no need to scroll to the top
* Collapse and Expand all buttons has been added for the left navbar
* The GCX code component should now take all the entire height from the body space on the  website.
* The code blocks should no longer have bold font

* New 404 docs design

This commit includes the new content and style applied to the antora 404 page.

* Update 404.hbs

This update includes the relative paths used on the live server

* Update 404.hbs

Changed location to /en/home

* 404 footer fix

The footer for the 404 page should now be fixed at the bottom of the device

* 404 Fixes

Fixed 404 design for mobile and error on console fixed

* Update 404.hbs

Testing permissions

* Update 404.hbs

Fixed relative paths on 404 page

---------

Co-authored-by: Kenni Martínez <57879404+KenniM@users.noreply.github.com>

* Fix 404 encoding (#61)

* Initial rebranding styles

Changed header and footer background color for both light and dark modes

* Initial rebranding styles

* Fixing styles

The headings should no longer be underlined and cards should now show have black as font color in dark mode

* Fixes in links

The links and titles should now show properly in cards for both dark and light modes

* Rebranding styles

This commit includes multiple changes for the rebranding styles, like changing some colors.
* The right content bar should now be sticky to the page, making it always available with no need to scroll to the top
* Collapse and Expand all buttons has been added for the left navbar
* The GCX code component should now take all the entire height from the body space on the  website.
* The code blocks should no longer have bold font

* New 404 docs design

This commit includes the new content and style applied to the antora 404 page.

* Update 404.hbs

This update includes the relative paths used on the live server

* Update 404.hbs

Changed location to /en/home

* 404 footer fix

The footer for the 404 page should now be fixed at the bottom of the device

* 404 Fixes

Fixed 404 design for mobile and error on console fixed

* Update 404.hbs

Testing permissions

* Update 404.hbs

Fixed relative paths on 404 page

* Updated 404.hbs

This should fix the encoding for this page.

* Change L88 to use single plain quote in the word can't

---------

Co-authored-by: Kenni Martínez <57879404+KenniM@users.noreply.github.com>
Co-authored-by: John Smart <johnsmartnh@gmail.com>

* Left Nav Improvements (#65)

This should fix a visual issue when using some new types of nav elements

Co-authored-by: Kenni Martínez <57879404+KenniM@users.noreply.github.com>

* Update README.adoc

* Update README.adoc

---------

Co-authored-by: Kenni Martínez <57879404+KenniM@users.noreply.github.com>
Co-authored-by: John Smart <johnsmartnh@gmail.com>
Co-authored-by: Eric Schneider <37347760+eric-schneider@users.noreply.github.com>

* Dependabot issues

Since the last check, only two new issues has been generated and tested.

The build was generated with no problems

---------

Co-authored-by: Kenni Martínez <57879404+KenniM@users.noreply.github.com>
Co-authored-by: John Smart <johnsmartnh@gmail.com>
Co-authored-by: Eric Schneider <37347760+eric-schneider@users.noreply.github.com>
Co-authored-by: Josué Bran <josuebran@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants