Avoid response buffering for ISeq response body#528
Merged
weavejester merged 1 commit intoring-clojure:masterfrom Jun 28, 2025
Merged
Avoid response buffering for ISeq response body#528weavejester merged 1 commit intoring-clojure:masterfrom
weavejester merged 1 commit intoring-clojure:masterfrom
Conversation
Member
|
Thanks for the update. Can you change the commit message to: This makes it clearer which system is being affected by this change. There's no need to create a new PR for this - just |
Member
|
Thanks for the update! Unfortunately I didn't notice this change before I added to the tests (GitHub only notifies me about comments, not new commits), so there's a minor conflict in the test file. Can you rebase and fix it, then I'll go ahead and merge it ready for Ring 1.15.0. |
Update the StreamableResponseBody implementation for ISeq to flush the OutputStream after each element. This prevents unnecessary delays when dealing with blocking seqs, for example, when being used to implement SSEs.
Contributor
Author
|
@weavejester Thanks for considering the PR! I have rebased and fixed it. |
Member
|
Merged. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes
StreamableResponseBodyimplementation forISeqavoid response buffering, which is useful when theISeqelements are delayed at source. This also allows for a smooth Server-sent Events flow.Consider the example usage below: