Avoid response buffering for ISeq response body#527
Avoid response buffering for ISeq response body#527kumarshantanu wants to merge 0 commit intoring-clojure:masterfrom
Conversation
|
Thanks for the PR. Can you ensure the commit messages follow the seven rules of a great git commit message as mentioned in the contributing guidelines. Secondly, can you think of a way of testing the changes you've made? |
|
@weavejester Thanks for the feedback - I have made the changes (edited the commit message, and reverted a commit that broke a test). |
|
Thanks! Can you remove the commit you reverted and its reversion, so there's just one commit left. Can you also add a test for the change you made. |
|
Created PR #528 with removed unwanted commits, and a test for flushing of body. |
|
For future reference, you don't need to create a new PR to do this. You can just force-push your changes and the PR will be updated. This is preferred, as it keeps the comments in one place. |
|
Noted. Force push after a git reset (to get rid of the unwanted commits) automatically closed the PR, so it was accidental. I should have made the new commits before the force push. |
This PR makes
StreamableResponseBodyimplementation forISeqavoid response buffering, which is useful when theISeqelements are delayed at source. This also allows for a smooth Server-sent Events flow.Consider the example usage below: