Group-8 : SonarQube suggested changes for Fragments folder

build.gradle

@@ -1,5 +1,3 @@
-apply plugin: 'com.android.application'
-
 buildscript {
     repositories {
         google()
@@ -10,6 +8,12 @@ buildscript {
     }
 }
 
+plugins {
+    id "org.sonarqube" version "4.4.1.3373"
+}
+
+apply plugin: 'com.android.application'
+
 allprojects {
     repositories {
         google()

src/main/java/de/dennisguse/opentracks/fragments/ChooseActivityTypeDialogFragment.java

@@ -23,12 +23,19 @@ public class ChooseActivityTypeDialogFragment extends DialogFragment implements
 
     private static final String CHOOSE_ACTIVITY_TYPE_DIALOG_TAG = "chooseActivityType";
 
-    @Deprecated
+    /**
+     * @deprecated
+     */
+    @Deprecated(since="4.2", forRemoval=true)
     public static void showDialog(FragmentManager fragmentManager, Context context, String activityTypeLocalized) {
         ActivityType activityType = ActivityType.findByLocalizedString(context, activityTypeLocalized);
         showDialog(fragmentManager, activityType);
     }
 
+    /**
+     * @deprecated
+     */
+    @Deprecated(since="4.2", forRemoval=true)
     public static void showDialog(FragmentManager fragmentManager, ActivityType activityType) {
         new ChooseActivityTypeDialogFragment(activityType).show(fragmentManager, ChooseActivityTypeDialogFragment.CHOOSE_ACTIVITY_TYPE_DIALOG_TAG);
     }
@@ -57,7 +64,7 @@ public static void showDialog(FragmentManager fragmentManager, ActivityType acti
             ActivityType.WORKOUT
     );
 
-    private static int getPosition(Context context, ActivityType activityType) {
+    private static int getPosition(ActivityType activityType) {
         if (activityType == null) {
             return -1;
         }
@@ -93,7 +100,7 @@ public View onCreateView(@NonNull LayoutInflater inflater, ViewGroup container,
         }
 
         final ChooseActivityTypeImageAdapter imageAdapter = new ChooseActivityTypeImageAdapter(iconDrawableIds);
-        int position = getPosition(getContext(), preselectedActivityType);
+        int position = getPosition(preselectedActivityType);
         if (position != -1) {
             imageAdapter.setSelected(position);
         }
@@ -103,6 +110,7 @@ public View onCreateView(@NonNull LayoutInflater inflater, ViewGroup container,
         return viewBinding.getRoot();
     }
 
+    @Override
     public void onAttach(@NonNull Context context) {
         super.onAttach(context);
         try {

src/main/java/de/dennisguse/opentracks/fragments/StatisticsRecordedFragment.java

@@ -35,6 +35,7 @@
 import de.dennisguse.opentracks.data.ContentProviderUtils;
 import de.dennisguse.opentracks.data.models.ActivityType;
 import de.dennisguse.opentracks.data.models.DistanceFormatter;
+import de.dennisguse.opentracks.data.models.Speed;
 import de.dennisguse.opentracks.data.models.SpeedFormatter;
 import de.dennisguse.opentracks.data.models.Track;
 import de.dennisguse.opentracks.databinding.StatisticsRecordedBinding;
@@ -45,7 +46,8 @@
 import de.dennisguse.opentracks.util.StringUtils;
 
 /**
- * A fragment to display track statistics to the user for a recorded {@link Track}.
+ * A fragment to display track statistics to the user for a recorded
+ * {@link Track}.
  *
  * @author Sandor Dornbush
  * @author Rodrigo Damazio
@@ -78,7 +80,8 @@ public static StatisticsRecordedFragment newInstance(Track.Id trackId) {
     private UnitSystem unitSystem = UnitSystem.defaultUnitSystem();
     private boolean preferenceReportSpeed;
 
-    private final SharedPreferences.OnSharedPreferenceChangeListener sharedPreferenceChangeListener = (sharedPreferences, key) -> {
+    private final SharedPreferences.OnSharedPreferenceChangeListener sharedPreferenceChangeListener = (
+            sharedPreferences, key) -> {
         boolean updateUInecessary = false;
 
         if (PreferencesUtils.isKey(R.string.stats_units_key, key)) {
@@ -141,26 +144,29 @@ public void loadStatistics() {
         if (isResumed()) {
             getActivity().runOnUiThread(() -> {
                 if (isResumed()) {
-                    Track track = contentProviderUtils.getTrack(trackId);
-                    if (track == null) {
-                        Log.e(TAG, "track cannot be null");
+                    Track trackWithIds = contentProviderUtils.getTrack(trackId);
+                    if (trackWithIds == null) {
+                        Log.e(TAG, "trackWithIds cannot be null");
                         getActivity().finish();
                         return;
                     }
 
                     sensorStatistics = contentProviderUtils.getSensorStats(trackId);
 
-                    boolean prefsChanged = this.track == null || (!this.track.getActivityTypeLocalized().equals(track.getActivityTypeLocalized()));
-                    this.track = track;
+                    boolean prefsChanged = this.track == null
+                            || (!this.track.getActivityTypeLocalized().equals(trackWithIds.getActivityTypeLocalized()));
+                    this.track = trackWithIds;
                     if (prefsChanged) {
-                        sharedPreferenceChangeListener.onSharedPreferenceChanged(null, getString(R.string.stats_rate_key));
+                        sharedPreferenceChangeListener.onSharedPreferenceChanged(null,
+                                getString(R.string.stats_rate_key));
                     }
 
-                    loadTrackDescription(track);
+                    loadTrackDescription(trackWithIds);
                     updateUI();
                     updateSensorUI();
 
-                    ((TrackRecordedActivity) getActivity()).startPostponedEnterTransitionWith(viewBinding.statsActivityTypeIcon);
+                    ((TrackRecordedActivity) getActivity())
+                            .startPostponedEnterTransitionWith(viewBinding.statsActivityTypeIcon);
                 }
             });
         }
@@ -169,82 +175,102 @@ public void loadStatistics() {
     private void loadTrackDescription(@NonNull Track track) {
         viewBinding.statsNameValue.setText(track.getName());
         viewBinding.statsDescriptionValue.setText(track.getDescription());
-        viewBinding.statsStartDatetimeValue.setText(StringUtils.formatDateTimeWithOffsetIfDifferent(track.getStartTime()));
+        viewBinding.statsStartDatetimeValue
+                .setText(StringUtils.formatDateTimeWithOffsetIfDifferent(track.getStartTime()));
+    }
+
+    private void updateUISetTotalDistance(TrackStatistics trackStatistics) {
+        Pair<String, String> parts = DistanceFormatter.Builder()
+                .setUnit(unitSystem)
+                .build(getContext()).getDistanceParts(trackStatistics.getTotalDistance());
+
+        viewBinding.statsDistanceValue.setText(parts.first);
+        viewBinding.statsDistanceUnit.setText(parts.second);
+
+    }
+
+    private void updateUISetActivityType() {
+        Context context = getContext();
+        String localizedActivityType = track.getActivityTypeLocalized();
+        int iconDrawableId = ActivityType.findByLocalizedString(context, localizedActivityType)
+                .getIconDrawableId();
+        viewBinding.statsActivityTypeIcon.setImageDrawable(ContextCompat.getDrawable(getContext(), iconDrawableId));
+    }
+
+    private void updatedUISetTimeAndStartDatetime(TrackStatistics trackStatistics) {
+        viewBinding.statsMovingTimeValue.setText(StringUtils.formatElapsedTime(trackStatistics.getMovingTime()));
+        viewBinding.statsTotalTimeValue.setText(StringUtils.formatElapsedTime(trackStatistics.getTotalTime()));
+    }
+
+    private void updatedAverageSpeed(TrackStatistics trackStatistics, SpeedFormatter formatter) {
+        viewBinding.statsAverageSpeedLabel
+                .setText(preferenceReportSpeed ? R.string.stats_average_speed : R.string.stats_average_pace);
+
+        Pair<String, String> parts = formatter.getSpeedParts(trackStatistics.getAverageSpeed());
+        viewBinding.statsAverageSpeedValue.setText(parts.first);
+        viewBinding.statsAverageSpeedUnit.setText(parts.second);
+    }
+
+    private void updatedMaxSpeed(TrackStatistics trackStatistics, SpeedFormatter formatter) {
+        viewBinding.statsMaxSpeedLabel
+                .setText(preferenceReportSpeed ? R.string.stats_max_speed : R.string.stats_fastest_pace);
+
+        Pair<String, String> parts = formatter.getSpeedParts(trackStatistics.getMaxSpeed());
+        viewBinding.statsMaxSpeedValue.setText(parts.first);
+        viewBinding.statsMaxSpeedUnit.setText(parts.second);
+    }
+
+    private void updatedSetMovingSpeed(TrackStatistics trackStatistics, SpeedFormatter formatter) {
+        viewBinding.statsMovingSpeedLabel.setText(
+                preferenceReportSpeed ? R.string.stats_average_moving_speed : R.string.stats_average_moving_pace);
+
+        Pair<String, String> parts = formatter.getSpeedParts(trackStatistics.getAverageMovingSpeed());
+        viewBinding.statsMovingSpeedValue.setText(parts.first);
+        viewBinding.statsMovingSpeedUnit.setText(parts.second);
+    }
+
+    private void updatedSetAltitudeGainAndLoss(TrackStatistics trackStatistics) {
+        Float altitudeGain = trackStatistics.getTotalAltitudeGain();
+        Float altitudeLoss = trackStatistics.getTotalAltitudeLoss();
+
+        Pair<String, String> parts;
+
+        parts = StringUtils.getAltitudeParts(getContext(), altitudeGain, unitSystem);
+        viewBinding.statsAltitudeGainValue.setText(parts.first);
+        viewBinding.statsAltitudeGainUnit.setText(parts.second);
+
+        parts = StringUtils.getAltitudeParts(getContext(), altitudeLoss, unitSystem);
+        viewBinding.statsAltitudeLossValue.setText(parts.first);
+        viewBinding.statsAltitudeLossUnit.setText(parts.second);
+
+        boolean show = altitudeGain != null && altitudeLoss != null;
+        viewBinding.statsAltitudeGroup.setVisibility(show ? View.VISIBLE : View.GONE);
     }
 
     private void updateUI() {
         TrackStatistics trackStatistics = track.getTrackStatistics();
         // Set total distance
-        {
-            Pair<String, String> parts = DistanceFormatter.Builder()
-                    .setUnit(unitSystem)
-                    .build(getContext()).getDistanceParts(trackStatistics.getTotalDistance());
-
-            viewBinding.statsDistanceValue.setText(parts.first);
-            viewBinding.statsDistanceUnit.setText(parts.second);
-        }
+        updateUISetTotalDistance(trackStatistics);
 
         // Set activity type
-        {
-            Context context = getContext();
-            String localizedActivityType = track.getActivityTypeLocalized();
-            int iconDrawableId = ActivityType.findByLocalizedString(context, localizedActivityType)
-                    .getIconDrawableId();
-            viewBinding.statsActivityTypeIcon.setImageDrawable(ContextCompat.getDrawable(getContext(), iconDrawableId));
-        }
+        updateUISetActivityType();
 
         // Set time and start datetime
-        {
-            viewBinding.statsMovingTimeValue.setText(StringUtils.formatElapsedTime(trackStatistics.getMovingTime()));
-            viewBinding.statsTotalTimeValue.setText(StringUtils.formatElapsedTime(trackStatistics.getTotalTime()));
-        }
+        updatedUISetTimeAndStartDatetime(trackStatistics);
 
-        SpeedFormatter formatter = SpeedFormatter.Builder().setUnit(unitSystem).setReportSpeedOrPace(preferenceReportSpeed).build(getContext());
+        SpeedFormatter formatter = SpeedFormatter.Builder().setUnit(unitSystem)
+                .setReportSpeedOrPace(preferenceReportSpeed).build(getContext());
         // Set average speed/pace
-        {
-            viewBinding.statsAverageSpeedLabel.setText(preferenceReportSpeed ? R.string.stats_average_speed : R.string.stats_average_pace);
-
-            Pair<String, String> parts = formatter.getSpeedParts(trackStatistics.getAverageSpeed());
-            viewBinding.statsAverageSpeedValue.setText(parts.first);
-            viewBinding.statsAverageSpeedUnit.setText(parts.second);
-        }
+        updatedAverageSpeed(trackStatistics, formatter);
 
         // Set max speed/pace
-        {
-            viewBinding.statsMaxSpeedLabel.setText(preferenceReportSpeed ? R.string.stats_max_speed : R.string.stats_fastest_pace);
-
-            Pair<String, String> parts = formatter.getSpeedParts(trackStatistics.getMaxSpeed());
-            viewBinding.statsMaxSpeedValue.setText(parts.first);
-            viewBinding.statsMaxSpeedUnit.setText(parts.second);
-        }
+        updatedMaxSpeed(trackStatistics, formatter);
 
         // Set moving speed/pace
-        {
-            viewBinding.statsMovingSpeedLabel.setText(preferenceReportSpeed ? R.string.stats_average_moving_speed : R.string.stats_average_moving_pace);
-
-            Pair<String, String> parts = formatter.getSpeedParts(trackStatistics.getAverageMovingSpeed());
-            viewBinding.statsMovingSpeedValue.setText(parts.first);
-            viewBinding.statsMovingSpeedUnit.setText(parts.second);
-        }
+        updatedSetMovingSpeed(trackStatistics, formatter);
 
         // Set altitude gain and loss
-        {
-            Float altitudeGain_m = trackStatistics.getTotalAltitudeGain();
-            Float altitudeLoss_m = trackStatistics.getTotalAltitudeLoss();
-
-            Pair<String, String> parts;
-
-            parts = StringUtils.getAltitudeParts(getContext(), altitudeGain_m, unitSystem);
-            viewBinding.statsAltitudeGainValue.setText(parts.first);
-            viewBinding.statsAltitudeGainUnit.setText(parts.second);
-
-            parts = StringUtils.getAltitudeParts(getContext(), altitudeLoss_m, unitSystem);
-            viewBinding.statsAltitudeLossValue.setText(parts.first);
-            viewBinding.statsAltitudeLossUnit.setText(parts.second);
-
-            boolean show = altitudeGain_m != null && altitudeLoss_m != null;
-            viewBinding.statsAltitudeGroup.setVisibility(show ? View.VISIBLE : View.GONE);
-        }
+        updatedSetAltitudeGainAndLoss(trackStatistics);
     }
 
     private void updateSensorUI() {

src/main/java/de/dennisguse/opentracks/fragments/StatisticsRecordingFragment.java

@@ -38,8 +38,6 @@
  */
 public class StatisticsRecordingFragment extends Fragment {
 
-    private static final String TAG = StatisticsRecordingFragment.class.getSimpleName();
-
     public static Fragment newInstance() {
         return new StatisticsRecordingFragment();
     }