Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group-8 : SonarQube suggested changes for Fragments folder #47

Open
wants to merge 24 commits into
base: main
Choose a base branch
from

Conversation

kevwad
Copy link
Collaborator

@kevwad kevwad commented Feb 17, 2024

Suggestions provided by SonarQube for Fragments folder included, among others:

  • Removing unused parameters
  • Removing unused fields
  • Adding @OverRide annotation
  • Extracting Code blocks
  • Renaming local variable to match the regular expression

kevwad and others added 24 commits February 11, 2024 18:39
GH-1 : Added override to the function as suggested by SonarQube
Add 'since' and/or 'forRemoval' arguments to the @Depracated annotation
GH - 3 Remove this unused TAG private field
GH-4 : Remove this unused method parameter context.
Renamed "track" to "trackWithId"
Renamed "track" to "trackWithId". Issue - GH#9
GH-16 Added "@OverRide" annotation on the given method signature
Removed the unused parameter from the method called updateUISetActivityType() and at the method definition also.
Update StatisticsRecordedFragment.java
GH-21 Changed the altitudeLoss_m to altitudeLoss.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants