Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional typechecking with prettier update #3774

Merged
merged 15 commits into from
Jan 5, 2024
Merged

Additional typechecking with prettier update #3774

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
6b85165
move code quality deps to root, update config, temporarily downgrade …
bcolloran Jan 3, 2024
04ceca7
Merge branch 'main' into additional-type-checking
bcolloran Jan 3, 2024
b7a8f04
cleanup
bcolloran Jan 3, 2024
e5a7693
update prettier config for prettier 3.x
bcolloran Jan 3, 2024
b548a26
Merge branch 'additional-type-checking' of https://github.com/rilldat…
bcolloran Jan 3, 2024
19a8e5f
run prettier
bcolloran Jan 3, 2024
6dde931
ignore vendored files, leave comment about that
bcolloran Jan 4, 2024
9f4afb8
Merge branch 'main' into additional-typechecking-with-prettier-update
bcolloran Jan 4, 2024
6209d5c
add rollup.config.js to ts checked files
bcolloran Jan 4, 2024
170cd9c
update prettier config
bcolloran Jan 4, 2024
1658872
fix review comments
bcolloran Jan 5, 2024
0c0d9b4
fix group-uris.ts
bcolloran Jan 5, 2024
ad372e3
Merge branch 'main' into additional-typechecking-with-prettier-update
bcolloran Jan 5, 2024
bac89f9
fix dashboard-store-defaults
bcolloran Jan 5, 2024
9d4c8da
prettier post-merge fixes
bcolloran Jan 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
cleanup
  • Loading branch information
@bcolloran
bcolloran committed Jan 3, 2024
commit b7a8f04d82b8c4544063dea54ce6c0e9b8108c25
42 changes: 21 additions & 21 deletions .eslintrc.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ module.exports = {
extends: [
"eslint:recommended",
"plugin:@typescript-eslint/recommended",
'plugin:@typescript-eslint/recommended-type-checked',
'plugin:svelte/recommended',
"plugin:@typescript-eslint/recommended-type-checked",
Copy link
Contributor Author

@bcolloran bcolloran Jan 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added current recommended eslint typechecking rules, and then disabled failing rules below so that we can clean them up incrementally

"plugin:svelte/recommended",
"prettier",
],
parser: "@typescript-eslint/parser",
Expand Down Expand Up @@ -38,25 +38,25 @@ module.exports = {
"@typescript-eslint/no-unsafe-assignment": "warn",
"@typescript-eslint/no-unsafe-member-access": "warn",
"@typescript-eslint/no-unsafe-argument": "warn",
"@typescript-eslint/no-unsafe-member-access":"warn",
"@typescript-eslint/no-unsafe-call":"warn",
"@typescript-eslint/no-unsafe-assignment":"warn",
"@typescript-eslint/no-unsafe-argument":"warn",
"@typescript-eslint/no-unsafe-return":"warn",
"@typescript-eslint/no-floating-promises":"warn",
"@typescript-eslint/no-explicit-any":"warn",
"@typescript-eslint/no-unnecessary-type-assertion":"warn",
"@typescript-eslint/unbound-method":"warn",
"@typescript-eslint/require-await":"warn",
"@typescript-eslint/restrict-template-expressions":"warn",
"@typescript-eslint/no-redundant-type-constituents":"warn",
"@typescript-eslint/no-unsafe-enum-comparison":"warn",
"@typescript-eslint/no-misused-promises":"warn",
"@typescript-eslint/no-duplicate-enum-values":"warn",
"@typescript-eslint/ban-ts-comment":"warn",
"@typescript-eslint/await-thenable":"warn",
"@typescript-eslint/no-implied-eval":"warn",
"@typescript-eslint/no-base-to-string":"warn",
"@typescript-eslint/no-unsafe-member-access": "warn",
"@typescript-eslint/no-unsafe-call": "warn",
"@typescript-eslint/no-unsafe-assignment": "warn",
"@typescript-eslint/no-unsafe-argument": "warn",
"@typescript-eslint/no-unsafe-return": "warn",
"@typescript-eslint/no-floating-promises": "warn",
"@typescript-eslint/no-explicit-any": "warn",
"@typescript-eslint/no-unnecessary-type-assertion": "warn",
"@typescript-eslint/unbound-method": "warn",
"@typescript-eslint/require-await": "warn",
"@typescript-eslint/restrict-template-expressions": "warn",
"@typescript-eslint/no-redundant-type-constituents": "warn",
"@typescript-eslint/no-unsafe-enum-comparison": "warn",
"@typescript-eslint/no-misused-promises": "warn",
"@typescript-eslint/no-duplicate-enum-values": "warn",
"@typescript-eslint/ban-ts-comment": "warn",
"@typescript-eslint/await-thenable": "warn",
"@typescript-eslint/no-implied-eval": "warn",
"@typescript-eslint/no-base-to-string": "warn",
"svelte/no-at-html-tags": "warn",
},
};
1 change: 0 additions & 1 deletion docs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
"@docusaurus/theme-mermaid": "2.4.3",
"@mdx-js/react": "^1.6.22",
"@tsconfig/docusaurus": "^1.0.5",
"@typescript-eslint/eslint-plugin": "^6.17.0",
"clsx": "^1.1.1",
"docusaurus-gtm-plugin": "^0.0.2",
"prism-react-renderer": "^1.3.3",
Expand Down