Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional typechecking with prettier update #3774

Merged
merged 15 commits into from
Jan 5, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add rollup.config.js to ts checked files
  • Loading branch information
bcolloran committed Jan 4, 2024
commit 6209d5cd3fa80cea1840823a0d7cede4787e651c
1 change: 1 addition & 0 deletions tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -44,5 +44,6 @@
"**/*.ts",
"**/*.svelte",
"prettier.config.js",
bcolloran marked this conversation as resolved.
Show resolved Hide resolved
"**/rollup.config.js",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we instead use rollup.config.ts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I'm not sure. The rollup config we have is currently js not ts, and I don't know whether rollup includes a tsc preprocessing+compilation step for ts files. I think we can investigate in follow up work.

]
}