Add Python crate and improve error handling #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and rework some other stuff to be more rusty
* improves error support * improves libquilc.core loading * fixes libquilc.so missing symbols * adds lib tests * renames python module to libquil_py
notmgsk
commented
Aug 2, 2023
notmgsk
commented
Aug 2, 2023
BatmanAoD
reviewed
Aug 4, 2023
MarquessV
reviewed
Aug 9, 2023
python/src/lib.rs
Outdated
| ) | ||
| .unwrap(); | ||
| } | ||
| init_submodule("libquil_py", py, m)?; |
There was a problem hiding this comment.
module name should be libquil right?
Originally had it in the Python bindings, but if Python bindings (e.g. qcs-sdk-rust) depend on this library, they won't necessarily import the Python code and thus won't hit the path that loads libquilc.so. By having it in the library's init, we can ensure that libquilc.so is always loaded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR:
pythoncrate which provides bindings to build programs and chips, and compile programs (depends on an as-yet unmerged quilc change: Add chip parser and program stringer functions to the C library quil-lang/quilc#893)libquilc.sowere not visible to thelibsbcl.solibraryCloses #20
Closes #21
Closes #22