Skip to content

Commit

Permalink
Fix some missing 3.5 deprecation warning
Browse files Browse the repository at this point in the history
I'm working on getting LibSass running against 3.5 and notice some
specs for `call` with a string didn't have deprecation warnings.

I wasn't able to use sass-spec to generate the warning either. Looks
like there is a bug with generate. I haven't investiaged further.

Closes sass#1039
  • Loading branch information
xzyfer committed Dec 30, 2016
1 parent f5d566d commit 39fe677
Show file tree
Hide file tree
Showing 19 changed files with 50 additions and 2 deletions.
6 changes: 6 additions & 0 deletions spec/libsass-closed-issues/issue_1266/max-3.5/error
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
DEPRECATION WARNING: Passing a string to call() is deprecated and will be illegal
in Sass 4.0. Use call(get-function("max")) instead.

Error: "blah" is not a number for `max'
on line 3 of spec/libsass-closed-issues/issue_1266/max-3.5/input.scss
Use --trace for backtrace.
Empty file.
4 changes: 4 additions & 0 deletions spec/libsass-closed-issues/issue_1266/max-3.5/input.scss
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
$foo: 1 2 3 blah 4;
foo {
bar: call(max, $foo...);
}
4 changes: 4 additions & 0 deletions spec/libsass-closed-issues/issue_1266/max-3.5/options.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
:start_version: '3.5'
:warning_todo:
- dart-sass
1 change: 1 addition & 0 deletions spec/libsass-closed-issues/issue_1266/max-3.5/status
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
65
1 change: 1 addition & 0 deletions spec/libsass-closed-issues/issue_1266/max/options.yml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
:end_version: '3.4'
:warning_todo:
- dart-sass
6 changes: 6 additions & 0 deletions spec/libsass-closed-issues/issue_1266/min-3.5/error
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
DEPRECATION WARNING: Passing a string to call() is deprecated and will be illegal
in Sass 4.0. Use call(get-function("min")) instead.

Error: "blah" is not a number for `min'
on line 3 of spec/libsass-closed-issues/issue_1266/min-3.5/input.scss
Use --trace for backtrace.
Empty file.
4 changes: 4 additions & 0 deletions spec/libsass-closed-issues/issue_1266/min-3.5/input.scss
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
$foo: 1 2 3 blah 4;
foo {
bar: call(min, $foo...);
}
4 changes: 4 additions & 0 deletions spec/libsass-closed-issues/issue_1266/min-3.5/options.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
:start_version: '3.5'
:warning_todo:
- dart-sass
1 change: 1 addition & 0 deletions spec/libsass-closed-issues/issue_1266/min-3.5/status
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
65
1 change: 1 addition & 0 deletions spec/libsass-closed-issues/issue_1266/min/options.yml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
:end_version: '3.4'
:warning_todo:
- dart-sass
6 changes: 6 additions & 0 deletions spec/libsass-closed-issues/issue_1418/dynamic-3.5/error
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
DEPRECATION WARNING: Passing a string to call() is deprecated and will be illegal
in Sass 4.0. Use call(get-function("missing")) instead.

Error: Function missing doesn't support keyword arguments
on line 2 of spec/libsass-closed-issues/issue_1418/dynamic-3.5/input.scss
Use --trace for backtrace.
Empty file.
3 changes: 3 additions & 0 deletions spec/libsass-closed-issues/issue_1418/dynamic-3.5/input.scss
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
foo {
color: call(missing, $a: b);
}
3 changes: 3 additions & 0 deletions spec/libsass-closed-issues/issue_1418/dynamic-3.5/options.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
---
:start_version: '3.5'
:end_version: '3.5'
1 change: 1 addition & 0 deletions spec/libsass-closed-issues/issue_1418/dynamic-3.5/status
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
65
5 changes: 4 additions & 1 deletion spec/libsass-closed-issues/issue_1418/dynamic-4.0/error
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
Error: Plain CSS function missing doesn't support keyword arguments
DEPRECATION WARNING: Passing a string to call() is deprecated and will be illegal
in Sass 4.0. Use call(get-function("missing")) instead.

Error: Function missing doesn't support keyword arguments
on line 2 of /sass/spec/libsass-issues/issue_1418/dynamic-4.0/input.scss
Use --trace for backtrace.
2 changes: 1 addition & 1 deletion spec/libsass-closed-issues/issue_1418/dynamic/options.yml
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
:end_version: '3.5'
:end_version: '3.4'

0 comments on commit 39fe677

Please sign in to comment.