Fix some missing 3.5 deprecation warning #1039
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm working on getting LibSass running against 3.5 and notice some specs for `call` with a string didn't have deprecation warnings. I wasn't able to use sass-spec to generate the warning either. Looks like there is a bug with generate. I haven't investiaged further.
|
I've logged #1040 to track the issue with generate. |
xzyfer
added a commit
to xzyfer/sass-spec
that referenced
this pull request
Dec 30, 2016
I'm working on getting LibSass running against 3.5 and notice some specs for `call` with a string didn't have deprecation warnings. I wasn't able to use sass-spec to generate the warning either. Looks like there is a bug with generate. I haven't investiaged further. Closes sass#1039
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on getting LibSass running against 3.5 and notice some
specs for
callwith a string didn't have deprecation warnings.I wasn't able to use sass-spec to generate the warning either. Looks
like there is a bug with generate. I haven't investigated further.