-
-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(native): add Locale module #938
Merged
Merged
Changes from 3 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
fda7ded
Add locale bindings on macOS
zbaylin 2d3ba98
Merge branch 'master' of https://github.com/revery-ui/revery into fea…
zbaylin 510b807
Add Locale implementation on Linux
zbaylin 72d9e2f
Add locale implementation on Windows
zbaylin 40c72ec
Add locale to Environment
zbaylin 1f0efe3
Add a CAMLlocal to return
zbaylin 26da73b
Add missing newline to format script
zbaylin 49cf346
Free Windows pointer
zbaylin f07d3fc
Add test
zbaylin 2eed6b0
Fix tests
zbaylin eedb70b
Fix freeing based on platform
zbaylin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
external getUser: unit => string = "revery_getUserLocale"; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
#include <stdio.h> | ||
|
||
#include <caml/alloc.h> | ||
#include <caml/callback.h> | ||
#include <caml/memory.h> | ||
#include <caml/mlvalues.h> | ||
#include <string.h> | ||
|
||
#include "caml_values.h" | ||
|
||
#ifdef WIN32 | ||
#include "ReveryWin32.h" | ||
#elif __APPLE__ | ||
#include "ReveryCocoa.h" | ||
#else | ||
#include "ReveryGtk.h" | ||
#include <locale.h> | ||
#endif | ||
|
||
CAMLprim value revery_getUserLocale() { | ||
CAMLparam0(); | ||
char *ret; | ||
#ifdef __APPLE__ | ||
ret = revery_getUserLocale_cocoa(); | ||
#else | ||
ret = setlocale(LC_CTYPE, NULL); | ||
#endif | ||
CAMLreturn(caml_copy_string(ret)); | ||
zbaylin marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
#ifdef __APPLE__ | ||
#include <stdio.h> | ||
|
||
#import <Cocoa/Cocoa.h> | ||
|
||
char *revery_getUserLocale_cocoa() { | ||
NSLocale *nsLocale = [NSLocale currentLocale]; | ||
return (char *)[[nsLocale localeIdentifier] UTF8String]; | ||
zbaylin marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} | ||
#endif |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea to add a log for this