feat(native): add Locale module #938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryphe
reviewed
Jul 3, 2020
bryphe
reviewed
Jul 3, 2020
bryphe
reviewed
Jul 3, 2020
src/Core/App.re
Outdated
| @@ -255,6 +255,10 @@ let start = init => { | |||
|
|
|||
| Revery_Native.initApp(); | |||
|
|
|||
| AppLog.infof(m => | |||
| m("Operating in locale : %s", Revery_Native.Locale.getUser()) | |||
bryphe
reviewed
Jul 3, 2020
bryphe
reviewed
Jul 3, 2020
bryphe
reviewed
Jul 3, 2020
src/Native/locale.c
Outdated
| camlRet = caml_copy_string(ret); | ||
| free(ret); |
There was a problem hiding this comment.
This doesn't look like it's hitting the Windows path - just linux.
I guess we should check:
- Does
retneed to be freed for Apple? - Does
retneed to be freed for Windows? I think the answer is yes - Does
retneed to be freed for Linux?
If the answer is to all of those, we could free(ret) after the #ifdef/#endif block. Otherwise, if we just need to free some of them - we'd need to include it in the platform condition
There was a problem hiding this comment.
Yeah that was my bad. I fixed it in eedb70b. On Linux and macOS we dont need to free (in fact we segfault if we do, predictably). I added a shouldFree variable that I think makes it a bit clearer. Let me know if you think this is better!
There was a problem hiding this comment.
Looks good to me! Thanks @zbaylin
bryphe
approved these changes
Jul 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to get the current user (and maybe eventually system) locale information.