Skip to content

fix: remove code check dependency for primary branch protection check #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 21, 2025
Merged

fix: remove code check dependency for primary branch protection check #142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion evaluation_plans/osps/access_control/evaluations.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ func OSPS_AC_03() (evaluation *layer4.ControlEvaluation) {
"Maturity Level 3",
},
[]layer4.AssessmentStep{
reusable_steps.IsCodeRepo,
branchProtectionRestrictsPushes, // This checks branch protection, but not rulesets yet
},
)
Expand Down
3 changes: 0 additions & 3 deletions evaluation_plans/osps/access_control/steps.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,6 @@ func branchProtectionRestrictsPushes(payloadData any, _ map[string]*layer4.Chang
if message != "" {
return layer4.Unknown, message
}
if !payload.IsCodeRepo {
return layer4.NotApplicable, "Repository contains no code - skipping branch protection checks"
}
protectionData := payload.Repository.DefaultBranchRef.BranchProtectionRule

if protectionData.RestrictsPushes {
Expand Down
Loading