Skip to content

Conversation

@trumant
Copy link
Contributor

@trumant trumant commented Sep 21, 2025

This change closes issue #141 by updating the evaluation logic to remove any check on what the contents of the repository are.

This change was tested against revanite-io/example-osps-baseline-level-1 and correctly results in the following result for AC-03.01:

control-id: OSPS-AC-03
  result: Needs Review
  message: Branch protection rule prevents deletions
  corrupted-state: false
  assessments:
  - requirement-id: OSPS-AC-03.01
    applicability:
    - Maturity Level 1
    - Maturity Level 2
    - Maturity Level 3
    description: When a direct commit is attempted on the project's primary branch, an enforcement mechanism MUST prevent the change from being applied.
    result: Needs Review
    message: Branch protection rule does not restrict pushes or require approving reviews; Rulesets not yet evaluated.
    steps:
    - github.com/revanite-io/pvtr-github-repo/evaluation_plans/osps/access_control.branchProtectionRestrictsPushes
    steps-executed: 1
    start: "2025-09-21T13:02:37-04:00"
    end: "2025-09-21T13:02:37-04:00"

This change closes issue #141 by updating the evaluation logic to remove
any check on what the contents of the repository are.

This change was tested against `revanite-io/example-osps-baseline-level-1`
and correctly results in the following result for `AC-03.01`:

```yaml
control-id: OSPS-AC-03
  result: Needs Review
  message: Branch protection rule prevents deletions
  corrupted-state: false
  assessments:
  - requirement-id: OSPS-AC-03.01
    applicability:
    - Maturity Level 1
    - Maturity Level 2
    - Maturity Level 3
    description: When a direct commit is attempted on the project's primary branch, an enforcement mechanism MUST prevent the change from being applied.
    result: Needs Review
    message: Branch protection rule does not restrict pushes or require approving reviews; Rulesets not yet evaluated.
    steps:
    - github.com/revanite-io/pvtr-github-repo/evaluation_plans/osps/access_control.branchProtectionRestrictsPushes
    steps-executed: 1
    start: "2025-09-21T13:02:37-04:00"
    end: "2025-09-21T13:02:37-04:00"
```

Signed-off-by: Travis Truman <trumant@gmail.com>
@trumant trumant requested a review from a team as a code owner September 21, 2025 17:08
@github-actions github-actions bot added the fix label Sep 21, 2025
@kusari-inspector
Copy link

Kusari Inspector

Kusari Analysis Results:

Proceed with these changes

✅ No Flagged Issues Detected
All values appear to be within acceptable risk parameters.

No pinned version dependency changes, code issues or exposed secrets detected!

Note

View full detailed analysis result for more information on the output and the checks that were run.


@kusari-inspector rerun - Trigger a re-analysis of this PR
@kusari-inspector feedback [your message] - Send feedback to our AI and team
See Kusari's documentation for setup and configuration.
Commit: 1e99db8, performed at: 2025-09-21T17:08:16Z

Found this helpful? Give it a 👍 or 👎 reaction!

@trumant trumant merged commit c66be99 into main Sep 21, 2025
7 checks passed
@trumant trumant deleted the issues/141 branch September 21, 2025 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants