Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in IdempotencyId::combine that prevented correct storing of idempotency key in idempotency table #1723

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Fix bug in IdempotencyId::combine that prevented correct storing of idempotency key in idempotency table #1723

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: IdempotencyId::combine now generates the correct key for the i… 
…dempotency table.

BREAKING CHANGE: This commit changes the way idempotent invocations are queried. When upgrading from Restate 1.0 to 1.1 this commit will generate duplicated requests for idempotent invocations created ONLY during the 1.0 lifecycle. For new invocations, no duplicated requests will be generated.
  • Loading branch information
@slinkydeveloper
slinkydeveloper committed Jul 22, 2024
commit 6884454f5f9b1e16ef789f309856de4015df4001
2 changes: 1 addition & 1 deletion crates/types/src/identifiers.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -615,7 +615,7 @@ impl IdempotencyId {
idempotency_key: ByteString,
) -> Self {
IdempotencyId {
service_name: invocation_target.handler_name().clone(),
service_name: invocation_target.service_name().clone(),
slinkydeveloper marked this conversation as resolved.
Show resolved Hide resolved
service_key: invocation_target.key().map(|bs| bs.as_bytes().clone()),
service_handler: invocation_target.handler_name().clone(),
idempotency_key,
Expand Down
Loading