Fix bug in IdempotencyId::combine that prevented correct storing of idempotency key in idempotency table
#1723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Trying to evaluate the impact of this bug:
|
|
I tested with the linked e2e PR and it works fine. |
There was a problem hiding this comment.
Thanks a lot for discovering this issue and fixing it @slinkydeveloper. I had a question about the side effects of this change for our users.
…dempotency table. BREAKING CHANGE: This commit changes the way idempotent invocations are queried. When upgrading from Restate 1.0 to 1.1 this commit will generate duplicated requests for idempotent invocations created ONLY during the 1.0 lifecycle. For new invocations, no duplicated requests will be generated.
slinkydeveloper
force-pushed
the
fix-bug-idempotency-key
branch
from
1d2577f to
6884454
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.