-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add remote store protobuf/gRPC definitions #7674
Conversation
…ilding rust types from the proto definition We introduce re_remote_store_types with proto definition files for V0 remote store gRPC API. We also introduce re_remote_store_tpyes_builder that heaveily relies on tonic_build to build the actual rust code from protobuf files.
Deployed docs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! A few last things but we're very close.
@@ -16,6 +16,7 @@ pub fn viewer_to_server( | |||
// We set a very high limit, because we should be able to trust the server. | |||
// See https://github.com/rerun-io/rerun/issues/5268 for more | |||
max_incoming_frame_size: 2 * gigs, | |||
delay_blocking: Duration::from_millis(10), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A comment explaining what this is and why 10ms would be helpful?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, right, these are new fields (2 more incoming in the next rebase) from ewebsock
version 0.7
. Will add comments.
crates/build/re_remote_store_types_builder/src/bin/build_re_remote_store_types.rs
Show resolved
Hide resolved
crates/build/re_remote_store_types_builder/src/bin/build_re_remote_store_types.rs
Outdated
Show resolved
Hide resolved
crates/store/re_remote_store_types/proto/rerun/v0/remote_store.proto
Outdated
Show resolved
Hide resolved
…-spec' into zehiko/remote-store-spec
…ilding rust types from the proto definition We introduce re_remote_store_types with proto definition files for V0 remote store gRPC API. We also introduce re_remote_store_tpyes_builder that heaveily relies on tonic_build to build the actual rust code from protobuf files.
1fcfd83
to
abfb887
Compare
1a0556d
to
51e9b66
Compare
What
In this PR we aim to define initial version of the V0 storage node APIs in the form of grpc protobuf definition. We also want to:
(currently) Example usage:
Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerCHANGELOG.md
and the migration guideTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.