-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Initial V0 storage node API grpc spec #7634
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zehiko
added
the
exclude from changelog
PRs with this won't show up in CHANGELOG.md
label
Oct 8, 2024
Deployed docs
|
Im inferring from the big "WIP" in the title that this is a draft 😶 -- marking as such to unclog the review queue. |
teh-cmc
reviewed
Oct 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I like where this is going.
- I don't like the names
re_storage_types
andre_storage_types_builder
, in fact I just don't like "storage" in general. Whatever, I don't think that matters in the slightest right now. - Very happy about the codegen setup (unsurprisingly).
- Very happy about the duplicated types (unsurprisingly).
- Naming of all things will need some love in general, but we can do that later.
Co-authored-by: Clement Rey <cr.rey.clement@gmail.com>
Co-authored-by: Clement Rey <cr.rey.clement@gmail.com>
- get rid of unwraps - address of the lints TODO - Cargo.lock duplicates
(acidentally) closed in favour of #7674 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
In this PR we aim to define initial version of the V0 storage node APIs in the form of grpc protobuf definition. We also want to:
(currently) Example usage:
Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerCHANGELOG.md
and the migration guideTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.