Add button for copying and saving images #7156
Conversation
emilk
added
ui
|
Why exclude from changelog? Wasn't aware we had this previously already 😳 |
|
Related to |
There was a problem hiding this comment.
that code dupl makes me very sad, but giving it a pass-as-is anyways (although I'd really really appreciate fixing that)
Don't think it's time to close the linked ticket already or at least need a new one for EncodedImage which can't be saved and has a preview inconsistent from that (see also notes on Slack)
| for x in 0..w { | ||
| // NOTE: the name `y` is already taken for the coordinate, so we use `luma` here. | ||
| let [luma, u, v] = match pixel_format { | ||
| PixelFormat::NV12 => { |
There was a problem hiding this comment.
Duplication of the decoding makes me very uneasy. I'd rather we divide above's ImageInfo::from_xyz to get colors as well and then use that again. Otherwise, we'll keep on adding duplicated decoding logic.
Or easier just split this out into a standalone color_at_postion_for_pixel_format function that takes a blob, format and coordinate which you then can call here and above
There was a problem hiding this comment.
I unified it now, but at the cost of making it harder to add a new PixelFormat that is not chroma-downsampled. I'll leave it for the next person to improve.
emilk
added
include in changelog
and removed
exclude from changelog
We had it, but only if you selected the |
What
Saving an image now also works on web, which it didn't do in 0.17
Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerCHANGELOG.mdand the migration guideTo run all checks from
main, comment on the PR with@rerun-bot full-check.