Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save dialog on web is really confusing #7138

Open
emilk opened this issue Aug 10, 2024 · 4 comments
Open

Save dialog on web is really confusing #7138

emilk opened this issue Aug 10, 2024 · 4 comments
Labels
😤 annoying Something in the UI / SDK is annoying to use 🧑‍🎨 Design Requires UX/UI designer input good first issue Good for newcomers 🕸️ web regarding running the viewer in a browser

Comments

@emilk
Copy link
Member

emilk commented Aug 10, 2024

Visit https://rerun.io/viewer

Open any example, then Click "Rerun -> Save recording"

image

You'll see this popup:

image

When clicking "Ok", nothing happens.

I wonder if we really need that extra popup that rfd presents. We should be able to just prompt the download of the data on the first click instead.

@emilk emilk added 🪳 bug Something isn't working 👀 needs triage This issue needs to be triaged by the Rerun team 🕸️ web regarding running the viewer in a browser 🦟 regression A thing that used to work in an earlier release and removed 👀 needs triage This issue needs to be triaged by the Rerun team labels Aug 10, 2024
@jprochazk
Copy link
Member

jprochazk commented Aug 12, 2024

It works if you click on the click here to download your file text, I'm guessing the Ok there is just to close the dialog without downloading the file.

@emilk
Copy link
Member Author

emilk commented Aug 12, 2024

Oh no… ok, that confused the hell out of me. We should make a PR to rfd to improve this (unless it is already fixed in the latest version).

What do you think about the possibility of being able to directly start the file download on the first click – what would be required for that?

@emilk emilk changed the title Save dialog doesn't work on Web Save dialog on Web is really confusing Aug 12, 2024
@emilk emilk changed the title Save dialog on Web is really confusing Save dialog on web is really confusing Aug 12, 2024
@emilk emilk added 😤 annoying Something in the UI / SDK is annoying to use 🧑‍🎨 Design Requires UX/UI designer input and removed 🪳 bug Something isn't working 🦟 regression A thing that used to work in an earlier release labels Aug 12, 2024
@jprochazk
Copy link
Member

What do you think about the possibility of being able to directly start the file download on the first click – what would be required for that?

There was some PR in progress for that:

Looks like it stalled though

@jprochazk
Copy link
Member

Posted my thoughts in the original issue: PolyMeilex/rfd#128 (comment)

TL;DR: We could use better APIs in Chromium-based browsers, and otherwise fall back to the existing implementation

@emilk emilk added the good first issue Good for newcomers label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
😤 annoying Something in the UI / SDK is annoying to use 🧑‍🎨 Design Requires UX/UI designer input good first issue Good for newcomers 🕸️ web regarding running the viewer in a browser
Projects
None yet
Development

No branches or pull requests

2 participants