Better ui for Blobs, especially those representing images
#7128
Conversation
emilk
added
ui
crates/viewer/re_data_ui/src/blob.rs
Outdated
| // We ignore the logged `MediaType` component, because the user is looking | ||
| // at the blob specifically, not the entity as a whole! | ||
| let media_type = MediaType::guess_from_data(self); |
There was a problem hiding this comment.
Treating MediaType as an implied data-dependency for Blob and querying it here seems preferable to just guessing. This seems inline with the thing we will need to do with ImageBuffer anyways.
There was a problem hiding this comment.
Showing the actual mime of the actual blob has the advantage that it is true. That is: it can help a user debug if they accidentally log a .png image with a image/jpeg media-type.
In general I would prefer it if we did as few of these magical lookups as possible, and instead show the user what they select. If they click on specific component, then only show data about that component!
For Blob, the guessed media type should work for all common image formats anyways.
For ImageBuffer we do need the actually logged ImageFormat though, but then we should make that clear that the shown image is inferred from a sibling component, or we show the image when the entity is selected.
|
Testing this on web, I discovered a dormant bug: |
### What Main broken by #7128, which missed an updated to code recently introduced (#7071) ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/7139?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/7139?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! * [x] If have noted any breaking changes to the log API in `CHANGELOG.md` and the migration guide - [PR Build Summary](https://build.rerun.io/pr/7139) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
What
The UI for a
Blobnow shows the size and guessed MIME type of it.There is a button to save it to disk (or download, on web).
The file extension is guessed from the guessed MIME type.
If it is an image, it will be shown.
Single-row
Tooltip
Selection panel
Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerCHANGELOG.mdand the migration guideTo run all checks from
main, comment on the PR with@rerun-bot full-check.