Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Rust 1.76 #5908

Merged
merged 8 commits into from
Apr 11, 2024
Merged

Update to Rust 1.76 #5908

merged 8 commits into from
Apr 11, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Apr 11, 2024

What

I discovered the cargo doc step in our CI was taking over 7 minutes due to some bug in cargo doc. Updating Rust fixes this.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

Copy link

github-actions bot commented Apr 11, 2024

Deployed docs

Commit Link
6144539 https://landing-8yps6zzqf-rerun.vercel.app/docs

@emilk emilk marked this pull request as ready for review April 11, 2024 08:48
@teh-cmc
Copy link
Member

teh-cmc commented Apr 11, 2024

The cross-platform image is on its way; ill have a look at the CI failure in the mean time.

@Wumpf Wumpf self-requested a review April 11, 2024 10:02
@@ -152,6 +156,7 @@ allow = [

# TODO(emilk): enable more of these lints:
"clippy::cloned_instead_of_copied",
"clippy::iter_over_hash_type",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

happens too often? ah well

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More than twice, at this is too fun to fix this cycle :)

@teh-cmc
Copy link
Member

teh-cmc commented Apr 11, 2024

I have no idea why the web check is failing, except that it's related to sccache. There is a long history of issues of that nature between cargo tooling and sccache.

I'll disable it for now since @Wumpf is already refactoring it on another branch, and then we should be able to merge this.

@teh-cmc teh-cmc merged commit eecfdb4 into main Apr 11, 2024
36 checks passed
@teh-cmc teh-cmc deleted the emilk/rust-1.76 branch April 11, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants