-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracking issue: Speed up CI #3033
Labels
🧑💻 dev experience
developer experience (excluding CI)
📉 performance
Optimization, memory use, etc
🚢 CI
🎄 tracking issue
issue that tracks a bunch of subissues
Milestone
Comments
emilk
added
🎄 tracking issue
issue that tracks a bunch of subissues
🚢 CI
📉 performance
Optimization, memory use, etc
labels
Apr 10, 2024
Maybe some tricks can be learned from the CI section of For instance, it suggest setting A lot of the tricks in #5332 also apply to this |
Closed
5 tasks
emilk
pushed a commit
that referenced
this issue
Apr 10, 2024
### What * related to #3033 -- * Turned out most of the python lints issues I had locally (and did not see on ci) are about opencv-python missmatches. The way I fixed it should work fine with either though now! * Various python lints on ci now use pixi and run only when py files change. * update pixi version used on ci ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using newly built examples: [rerun.io/viewer](https://rerun.io/viewer/pr/5897) * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/5897?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/5897?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/5897) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
This was referenced Apr 11, 2024
emilk
added a commit
that referenced
this issue
Apr 11, 2024
* Part of #3033 ### What For PRs, skip: * Building a notebook (moved to `nightly`) * `cargo test` * `roundtrips.py` * `compare_snippet_output.py` ### Effect Total duration: 17m59s -> 12m39s Billable time: 1h15m -> 1h9m ### Checklist * [x] A box was cheked - [PR Build Summary](https://build.rerun.io/pr/5901) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
This was referenced Apr 11, 2024
Merged
teh-cmc
added a commit
that referenced
this issue
Apr 11, 2024
* Part of #3033 --------- Co-authored-by: Clement Rey <cr.rey.clement@gmail.com>
emilk
added a commit
that referenced
this issue
Apr 11, 2024
* Part of #3033 ### What It takes almost 3 minutes per PR. Pro: * I don't remember it ever catching a bug * I usually test the latest examples from `main` or `nightly` anyway Con: * No example size diff comparisons per PR * This breaks the <https://www.rerun.io/viewer/pr/5910> url, unless I also update the default manifest 🤔 Total duration: 12m -> 8m Billable time: 51m -> 43m ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using default manifest (nightly): [rerun.io/viewer](https://rerun.io/viewer/pr/5910) * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/5910?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/5910?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/5910) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🧑💻 dev experience
developer experience (excluding CI)
📉 performance
Optimization, memory use, etc
🚢 CI
🎄 tracking issue
issue that tracks a bunch of subissues
Speed up the wait time for each PR
demo.rerun.io
todemo
andtest
#2566.rrd
file generation (?)build web demo
job instead of waiting for those two to finish separately (and reusing their artifacts).- Cargo rebuilds a lot, even with cache during the Rust lints job
main
andnightly
cargo test
on mainCARGO_INCREMENTAL
selfThe text was updated successfully, but these errors were encountered: