Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace nb_things with num_things #1162

Merged
merged 6 commits into from
Feb 9, 2023
Merged

Replace nb_things with num_things #1162

merged 6 commits into from
Feb 9, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented Feb 9, 2023

Also adds a lint against it.

Motivation: https://twitter.com/ernerfeldt/status/1622620902297837572

I went with num_ here because it was the smaller change.

This is most important for out public APIs, but since we are open source, our entire source is our API :)

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I've added a line to CHANGELOG.md (if this is a big enough change to warrant it)

@emilk
Replace nb_things with num_things
17c83aa 
Also adds a lint against it.

Motivation: https://twitter.com/ernerfeldt/status/1622620902297837572

I went with `num_` here because it was the smaller change.
@emilk
Add tests to lint.py
4c7aa64
@emilk
py-format
39b6c32
@emilk emilk merged commit e7139d2 into main Feb 9, 2023
@emilk emilk deleted the emilk/nb_-to-num_ branch February 9, 2023 09:45
teh-cmc added a commit that referenced this pull request Feb 9, 2023
@teh-cmc
squash merge cmc/rerun_is_the_sdk
deeb823 
commit 640a1c6
Author: Clement Rey <cr.rey.clement@gmail.com>
Date:   Thu Feb 9 11:18:52 2023 +0100

    addressed PR comments

commit e495477
Merge: ad3940a 025dbe3
Author: Clement Rey <cr.rey.clement@gmail.com>
Date:   Thu Feb 9 11:15:40 2023 +0100

    Merge remote-tracking branch 'origin/main' into cmc/rerun_is_the_sdk

commit 025dbe3
Author: Andreas Reich <andreas@rerun.io>
Date:   Thu Feb 9 11:06:12 2023 +0100

    Fix incorrectly logged warnings on paths missing from the entity tree. (#1147)

    Reasoning detailed in the code comments.
    Took the opportunity to do a clarifying rename.

commit e7139d2
Author: Emil Ernerfeldt <emil@rerun.io>
Date:   Thu Feb 9 10:45:21 2023 +0100

    Replace `nb_things` with `num_things` (#1162)

    * Replace `nb_things` with `num_things`

    Also adds a lint against it.

    Motivation: https://twitter.com/ernerfeldt/status/1622620902297837572

    I went with `num_` here because it was the smaller change.

    * Add tests to lint.py

    * py-format

    * merge fix

    * chmod fix

commit d5b822c
Author: Emil Ernerfeldt <emil@rerun.io>
Date:   Thu Feb 9 09:52:55 2023 +0100

    Update some crates in anticipation of egui 0.21 (#1154)

    * Make sure we never depend on cmake

    * Update to pollster 0.3

    * Remove text-to-speech-related dependencies

    They shouldn't be needed, since we don't use tts

    * Use workspace versions of egui and eframe

    * use eframe 0.20.1 in Cargo.toml

    * Update eframe/egui and wasm-bindgen

    * downgrade toml crate to avoid duplicate crate

    * document deny.toml

    * Update to wasm-bindgen-cli v0.2.84 everywhere

    * Publish new ci_docker image with wasm-bindgen-cli 0.2.84

    * Better comment in deny.toml

    * Remove some unused crates found with cargo udeps

    * build fix (re-add unindent crate)

commit 9f1452d
Author: Emil Ernerfeldt <emil@rerun.io>
Date:   Thu Feb 9 09:51:55 2023 +0100

    Improve the dev docs and top-level README.md (#1133)

    * Create a BUILD.md and CODE_STYLE.md

    * Move docs about how to build docs to BUILD.md

    * Improve example docs

    * Remove `python -m rerun` instructions (`rerun` should work just as well)

    * Explain justfile

    * Explain taplo.toml

    * Create dummy ARCHITECTURE.md and interlink all dev-docs

    * Start filling out ARCHITECTURE.md

    * Strip down README.md to its minimum

    * Document some of the major technologies

    * "Wasm" should not be written as WASM

    * Add a section about immediate mode

    * Add link to benchmarks

    * Fix link in TODO

    * Add list of shortcomings

    * a short section about the native viewer

    Co-authored-by: Jeremy Leibs <jeremy@rerun.io>

    * Improve the buisness model section

    Co-authored-by: Nikolaus West <niko@grapic.co>

    * User feedback

    * Unrelated code cleanup

    ---------

    Co-authored-by: Jeremy Leibs <jeremy@rerun.io>
    Co-authored-by: Nikolaus West <niko@grapic.co>
teh-cmc added a commit that referenced this pull request Feb 9, 2023
@teh-cmc
squash merge main
407f7a1 
commit 9108c86
Author: Clement Rey <cr.rey.clement@gmail.com>
Date:   Thu Feb 9 11:32:39 2023 +0100

    The main `rerun` crate is now the public facing SDK (#1151)

    * main rerun crate now exposes the SDK

    * the sdk shall never depend directly on eframe

    * SDK crate is now mostly for internal use -> re_sdk

    * make sdk feature on by default

    * how did that guy get in

    * using new feature flag for optional dep thing

    * grabbing the SDK through 'rerun' implies access to the viewer

    * fmt

    * carrying glam aaaallll the way

    * addressed PR comments

commit 025dbe3
Author: Andreas Reich <andreas@rerun.io>
Date:   Thu Feb 9 11:06:12 2023 +0100

    Fix incorrectly logged warnings on paths missing from the entity tree. (#1147)

    Reasoning detailed in the code comments.
    Took the opportunity to do a clarifying rename.

commit e7139d2
Author: Emil Ernerfeldt <emil@rerun.io>
Date:   Thu Feb 9 10:45:21 2023 +0100

    Replace `nb_things` with `num_things` (#1162)

    * Replace `nb_things` with `num_things`

    Also adds a lint against it.

    Motivation: https://twitter.com/ernerfeldt/status/1622620902297837572

    I went with `num_` here because it was the smaller change.

    * Add tests to lint.py

    * py-format

    * merge fix

    * chmod fix

commit d5b822c
Author: Emil Ernerfeldt <emil@rerun.io>
Date:   Thu Feb 9 09:52:55 2023 +0100

    Update some crates in anticipation of egui 0.21 (#1154)

    * Make sure we never depend on cmake

    * Update to pollster 0.3

    * Remove text-to-speech-related dependencies

    They shouldn't be needed, since we don't use tts

    * Use workspace versions of egui and eframe

    * use eframe 0.20.1 in Cargo.toml

    * Update eframe/egui and wasm-bindgen

    * downgrade toml crate to avoid duplicate crate

    * document deny.toml

    * Update to wasm-bindgen-cli v0.2.84 everywhere

    * Publish new ci_docker image with wasm-bindgen-cli 0.2.84

    * Better comment in deny.toml

    * Remove some unused crates found with cargo udeps

    * build fix (re-add unindent crate)

commit 9f1452d
Author: Emil Ernerfeldt <emil@rerun.io>
Date:   Thu Feb 9 09:51:55 2023 +0100

    Improve the dev docs and top-level README.md (#1133)

    * Create a BUILD.md and CODE_STYLE.md

    * Move docs about how to build docs to BUILD.md

    * Improve example docs

    * Remove `python -m rerun` instructions (`rerun` should work just as well)

    * Explain justfile

    * Explain taplo.toml

    * Create dummy ARCHITECTURE.md and interlink all dev-docs

    * Start filling out ARCHITECTURE.md

    * Strip down README.md to its minimum

    * Document some of the major technologies

    * "Wasm" should not be written as WASM

    * Add a section about immediate mode

    * Add link to benchmarks

    * Fix link in TODO

    * Add list of shortcomings

    * a short section about the native viewer

    Co-authored-by: Jeremy Leibs <jeremy@rerun.io>

    * Improve the buisness model section

    Co-authored-by: Nikolaus West <niko@grapic.co>

    * User feedback

    * Unrelated code cleanup

    ---------

    Co-authored-by: Jeremy Leibs <jeremy@rerun.io>
    Co-authored-by: Nikolaus West <niko@grapic.co>
teh-cmc added a commit that referenced this pull request Feb 9, 2023
@teh-cmc @emilk
Barebone examples and slightly friendlier show() for Rust (#1153)
0904dc1 
* main rerun crate now exposes the SDK

* the sdk shall never depend directly on eframe

* SDK crate is now mostly for internal use -> re_sdk

* make sdk feature on by default

* how did that guy get in

* using new feature flag for optional dep thing

* grabbing the SDK through 'rerun' implies access to the viewer

* fmt

* carrying glam aaaallll the way

* add barebone usage examples

* introduce a better show() for rust

* use new show() in barebone examples

* fmt

* squash merge cmc/rerun_is_the_sdk

commit 640a1c6
Author: Clement Rey <cr.rey.clement@gmail.com>
Date:   Thu Feb 9 11:18:52 2023 +0100

    addressed PR comments

commit e495477
Merge: ad3940a 025dbe3
Author: Clement Rey <cr.rey.clement@gmail.com>
Date:   Thu Feb 9 11:15:40 2023 +0100

    Merge remote-tracking branch 'origin/main' into cmc/rerun_is_the_sdk

commit 025dbe3
Author: Andreas Reich <andreas@rerun.io>
Date:   Thu Feb 9 11:06:12 2023 +0100

    Fix incorrectly logged warnings on paths missing from the entity tree. (#1147)

    Reasoning detailed in the code comments.
    Took the opportunity to do a clarifying rename.

commit e7139d2
Author: Emil Ernerfeldt <emil@rerun.io>
Date:   Thu Feb 9 10:45:21 2023 +0100

    Replace `nb_things` with `num_things` (#1162)

    * Replace `nb_things` with `num_things`

    Also adds a lint against it.

    Motivation: https://twitter.com/ernerfeldt/status/1622620902297837572

    I went with `num_` here because it was the smaller change.

    * Add tests to lint.py

    * py-format

    * merge fix

    * chmod fix

commit d5b822c
Author: Emil Ernerfeldt <emil@rerun.io>
Date:   Thu Feb 9 09:52:55 2023 +0100

    Update some crates in anticipation of egui 0.21 (#1154)

    * Make sure we never depend on cmake

    * Update to pollster 0.3

    * Remove text-to-speech-related dependencies

    They shouldn't be needed, since we don't use tts

    * Use workspace versions of egui and eframe

    * use eframe 0.20.1 in Cargo.toml

    * Update eframe/egui and wasm-bindgen

    * downgrade toml crate to avoid duplicate crate

    * document deny.toml

    * Update to wasm-bindgen-cli v0.2.84 everywhere

    * Publish new ci_docker image with wasm-bindgen-cli 0.2.84

    * Better comment in deny.toml

    * Remove some unused crates found with cargo udeps

    * build fix (re-add unindent crate)

commit 9f1452d
Author: Emil Ernerfeldt <emil@rerun.io>
Date:   Thu Feb 9 09:51:55 2023 +0100

    Improve the dev docs and top-level README.md (#1133)

    * Create a BUILD.md and CODE_STYLE.md

    * Move docs about how to build docs to BUILD.md

    * Improve example docs

    * Remove `python -m rerun` instructions (`rerun` should work just as well)

    * Explain justfile

    * Explain taplo.toml

    * Create dummy ARCHITECTURE.md and interlink all dev-docs

    * Start filling out ARCHITECTURE.md

    * Strip down README.md to its minimum

    * Document some of the major technologies

    * "Wasm" should not be written as WASM

    * Add a section about immediate mode

    * Add link to benchmarks

    * Fix link in TODO

    * Add list of shortcomings

    * a short section about the native viewer

    Co-authored-by: Jeremy Leibs <jeremy@rerun.io>

    * Improve the buisness model section

    Co-authored-by: Nikolaus West <niko@grapic.co>

    * User feedback

    * Unrelated code cleanup

    ---------

    Co-authored-by: Jeremy Leibs <jeremy@rerun.io>
    Co-authored-by: Nikolaus West <niko@grapic.co>

* lost a glam reexport in translation

* minimal python example with color cube

* minimal rust example with color cube

* saying goodbye to hello_world

* requirements, fmt...

* squash merge main

commit 9108c86
Author: Clement Rey <cr.rey.clement@gmail.com>
Date:   Thu Feb 9 11:32:39 2023 +0100

    The main `rerun` crate is now the public facing SDK (#1151)

    * main rerun crate now exposes the SDK

    * the sdk shall never depend directly on eframe

    * SDK crate is now mostly for internal use -> re_sdk

    * make sdk feature on by default

    * how did that guy get in

    * using new feature flag for optional dep thing

    * grabbing the SDK through 'rerun' implies access to the viewer

    * fmt

    * carrying glam aaaallll the way

    * addressed PR comments

commit 025dbe3
Author: Andreas Reich <andreas@rerun.io>
Date:   Thu Feb 9 11:06:12 2023 +0100

    Fix incorrectly logged warnings on paths missing from the entity tree. (#1147)

    Reasoning detailed in the code comments.
    Took the opportunity to do a clarifying rename.

commit e7139d2
Author: Emil Ernerfeldt <emil@rerun.io>
Date:   Thu Feb 9 10:45:21 2023 +0100

    Replace `nb_things` with `num_things` (#1162)

    * Replace `nb_things` with `num_things`

    Also adds a lint against it.

    Motivation: https://twitter.com/ernerfeldt/status/1622620902297837572

    I went with `num_` here because it was the smaller change.

    * Add tests to lint.py

    * py-format

    * merge fix

    * chmod fix

commit d5b822c
Author: Emil Ernerfeldt <emil@rerun.io>
Date:   Thu Feb 9 09:52:55 2023 +0100

    Update some crates in anticipation of egui 0.21 (#1154)

    * Make sure we never depend on cmake

    * Update to pollster 0.3

    * Remove text-to-speech-related dependencies

    They shouldn't be needed, since we don't use tts

    * Use workspace versions of egui and eframe

    * use eframe 0.20.1 in Cargo.toml

    * Update eframe/egui and wasm-bindgen

    * downgrade toml crate to avoid duplicate crate

    * document deny.toml

    * Update to wasm-bindgen-cli v0.2.84 everywhere

    * Publish new ci_docker image with wasm-bindgen-cli 0.2.84

    * Better comment in deny.toml

    * Remove some unused crates found with cargo udeps

    * build fix (re-add unindent crate)

commit 9f1452d
Author: Emil Ernerfeldt <emil@rerun.io>
Date:   Thu Feb 9 09:51:55 2023 +0100

    Improve the dev docs and top-level README.md (#1133)

    * Create a BUILD.md and CODE_STYLE.md

    * Move docs about how to build docs to BUILD.md

    * Improve example docs

    * Remove `python -m rerun` instructions (`rerun` should work just as well)

    * Explain justfile

    * Explain taplo.toml

    * Create dummy ARCHITECTURE.md and interlink all dev-docs

    * Start filling out ARCHITECTURE.md

    * Strip down README.md to its minimum

    * Document some of the major technologies

    * "Wasm" should not be written as WASM

    * Add a section about immediate mode

    * Add link to benchmarks

    * Fix link in TODO

    * Add list of shortcomings

    * a short section about the native viewer

    Co-authored-by: Jeremy Leibs <jeremy@rerun.io>

    * Improve the buisness model section

    Co-authored-by: Nikolaus West <niko@grapic.co>

    * User feedback

    * Unrelated code cleanup

    ---------

    Co-authored-by: Jeremy Leibs <jeremy@rerun.io>
    Co-authored-by: Nikolaus West <niko@grapic.co>

* merge conflict

* Session::show docstring

* addressed PR comments

Co-authored-by: Emil Ernerfeldt <emil@rerun.io>

* use new ColorRGBA constructors everywhere

---------

Co-authored-by: Emil Ernerfeldt <emil@rerun.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jondo2010 jondo2010 jondo2010 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emilk @jondo2010