-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update some crates in anticipation of egui 0.21 #1154
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They shouldn't be needed, since we don't use tts
emilk
changed the title
Update some crates
Update some crates in anticipation of egui 0.21
Feb 9, 2023
jondo2010
reviewed
Feb 9, 2023
@@ -22,6 +30,7 @@ multiple-versions = "deny" | |||
wildcards = "allow" # at least until https://github.com/EmbarkStudios/cargo-deny/issues/241 is fixed | |||
deny = [ | |||
{ name = "cgmath" }, # We use glam | |||
{ name = "cmake" }, # Never again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
jondo2010
approved these changes
Feb 9, 2023
teh-cmc
added a commit
that referenced
this pull request
Feb 9, 2023
commit 640a1c6 Author: Clement Rey <cr.rey.clement@gmail.com> Date: Thu Feb 9 11:18:52 2023 +0100 addressed PR comments commit e495477 Merge: ad3940a 025dbe3 Author: Clement Rey <cr.rey.clement@gmail.com> Date: Thu Feb 9 11:15:40 2023 +0100 Merge remote-tracking branch 'origin/main' into cmc/rerun_is_the_sdk commit 025dbe3 Author: Andreas Reich <andreas@rerun.io> Date: Thu Feb 9 11:06:12 2023 +0100 Fix incorrectly logged warnings on paths missing from the entity tree. (#1147) Reasoning detailed in the code comments. Took the opportunity to do a clarifying rename. commit e7139d2 Author: Emil Ernerfeldt <emil@rerun.io> Date: Thu Feb 9 10:45:21 2023 +0100 Replace `nb_things` with `num_things` (#1162) * Replace `nb_things` with `num_things` Also adds a lint against it. Motivation: https://twitter.com/ernerfeldt/status/1622620902297837572 I went with `num_` here because it was the smaller change. * Add tests to lint.py * py-format * merge fix * chmod fix commit d5b822c Author: Emil Ernerfeldt <emil@rerun.io> Date: Thu Feb 9 09:52:55 2023 +0100 Update some crates in anticipation of egui 0.21 (#1154) * Make sure we never depend on cmake * Update to pollster 0.3 * Remove text-to-speech-related dependencies They shouldn't be needed, since we don't use tts * Use workspace versions of egui and eframe * use eframe 0.20.1 in Cargo.toml * Update eframe/egui and wasm-bindgen * downgrade toml crate to avoid duplicate crate * document deny.toml * Update to wasm-bindgen-cli v0.2.84 everywhere * Publish new ci_docker image with wasm-bindgen-cli 0.2.84 * Better comment in deny.toml * Remove some unused crates found with cargo udeps * build fix (re-add unindent crate) commit 9f1452d Author: Emil Ernerfeldt <emil@rerun.io> Date: Thu Feb 9 09:51:55 2023 +0100 Improve the dev docs and top-level README.md (#1133) * Create a BUILD.md and CODE_STYLE.md * Move docs about how to build docs to BUILD.md * Improve example docs * Remove `python -m rerun` instructions (`rerun` should work just as well) * Explain justfile * Explain taplo.toml * Create dummy ARCHITECTURE.md and interlink all dev-docs * Start filling out ARCHITECTURE.md * Strip down README.md to its minimum * Document some of the major technologies * "Wasm" should not be written as WASM * Add a section about immediate mode * Add link to benchmarks * Fix link in TODO * Add list of shortcomings * a short section about the native viewer Co-authored-by: Jeremy Leibs <jeremy@rerun.io> * Improve the buisness model section Co-authored-by: Nikolaus West <niko@grapic.co> * User feedback * Unrelated code cleanup --------- Co-authored-by: Jeremy Leibs <jeremy@rerun.io> Co-authored-by: Nikolaus West <niko@grapic.co>
teh-cmc
added a commit
that referenced
this pull request
Feb 9, 2023
commit 9108c86 Author: Clement Rey <cr.rey.clement@gmail.com> Date: Thu Feb 9 11:32:39 2023 +0100 The main `rerun` crate is now the public facing SDK (#1151) * main rerun crate now exposes the SDK * the sdk shall never depend directly on eframe * SDK crate is now mostly for internal use -> re_sdk * make sdk feature on by default * how did that guy get in * using new feature flag for optional dep thing * grabbing the SDK through 'rerun' implies access to the viewer * fmt * carrying glam aaaallll the way * addressed PR comments commit 025dbe3 Author: Andreas Reich <andreas@rerun.io> Date: Thu Feb 9 11:06:12 2023 +0100 Fix incorrectly logged warnings on paths missing from the entity tree. (#1147) Reasoning detailed in the code comments. Took the opportunity to do a clarifying rename. commit e7139d2 Author: Emil Ernerfeldt <emil@rerun.io> Date: Thu Feb 9 10:45:21 2023 +0100 Replace `nb_things` with `num_things` (#1162) * Replace `nb_things` with `num_things` Also adds a lint against it. Motivation: https://twitter.com/ernerfeldt/status/1622620902297837572 I went with `num_` here because it was the smaller change. * Add tests to lint.py * py-format * merge fix * chmod fix commit d5b822c Author: Emil Ernerfeldt <emil@rerun.io> Date: Thu Feb 9 09:52:55 2023 +0100 Update some crates in anticipation of egui 0.21 (#1154) * Make sure we never depend on cmake * Update to pollster 0.3 * Remove text-to-speech-related dependencies They shouldn't be needed, since we don't use tts * Use workspace versions of egui and eframe * use eframe 0.20.1 in Cargo.toml * Update eframe/egui and wasm-bindgen * downgrade toml crate to avoid duplicate crate * document deny.toml * Update to wasm-bindgen-cli v0.2.84 everywhere * Publish new ci_docker image with wasm-bindgen-cli 0.2.84 * Better comment in deny.toml * Remove some unused crates found with cargo udeps * build fix (re-add unindent crate) commit 9f1452d Author: Emil Ernerfeldt <emil@rerun.io> Date: Thu Feb 9 09:51:55 2023 +0100 Improve the dev docs and top-level README.md (#1133) * Create a BUILD.md and CODE_STYLE.md * Move docs about how to build docs to BUILD.md * Improve example docs * Remove `python -m rerun` instructions (`rerun` should work just as well) * Explain justfile * Explain taplo.toml * Create dummy ARCHITECTURE.md and interlink all dev-docs * Start filling out ARCHITECTURE.md * Strip down README.md to its minimum * Document some of the major technologies * "Wasm" should not be written as WASM * Add a section about immediate mode * Add link to benchmarks * Fix link in TODO * Add list of shortcomings * a short section about the native viewer Co-authored-by: Jeremy Leibs <jeremy@rerun.io> * Improve the buisness model section Co-authored-by: Nikolaus West <niko@grapic.co> * User feedback * Unrelated code cleanup --------- Co-authored-by: Jeremy Leibs <jeremy@rerun.io> Co-authored-by: Nikolaus West <niko@grapic.co>
teh-cmc
added a commit
that referenced
this pull request
Feb 9, 2023
* main rerun crate now exposes the SDK * the sdk shall never depend directly on eframe * SDK crate is now mostly for internal use -> re_sdk * make sdk feature on by default * how did that guy get in * using new feature flag for optional dep thing * grabbing the SDK through 'rerun' implies access to the viewer * fmt * carrying glam aaaallll the way * add barebone usage examples * introduce a better show() for rust * use new show() in barebone examples * fmt * squash merge cmc/rerun_is_the_sdk commit 640a1c6 Author: Clement Rey <cr.rey.clement@gmail.com> Date: Thu Feb 9 11:18:52 2023 +0100 addressed PR comments commit e495477 Merge: ad3940a 025dbe3 Author: Clement Rey <cr.rey.clement@gmail.com> Date: Thu Feb 9 11:15:40 2023 +0100 Merge remote-tracking branch 'origin/main' into cmc/rerun_is_the_sdk commit 025dbe3 Author: Andreas Reich <andreas@rerun.io> Date: Thu Feb 9 11:06:12 2023 +0100 Fix incorrectly logged warnings on paths missing from the entity tree. (#1147) Reasoning detailed in the code comments. Took the opportunity to do a clarifying rename. commit e7139d2 Author: Emil Ernerfeldt <emil@rerun.io> Date: Thu Feb 9 10:45:21 2023 +0100 Replace `nb_things` with `num_things` (#1162) * Replace `nb_things` with `num_things` Also adds a lint against it. Motivation: https://twitter.com/ernerfeldt/status/1622620902297837572 I went with `num_` here because it was the smaller change. * Add tests to lint.py * py-format * merge fix * chmod fix commit d5b822c Author: Emil Ernerfeldt <emil@rerun.io> Date: Thu Feb 9 09:52:55 2023 +0100 Update some crates in anticipation of egui 0.21 (#1154) * Make sure we never depend on cmake * Update to pollster 0.3 * Remove text-to-speech-related dependencies They shouldn't be needed, since we don't use tts * Use workspace versions of egui and eframe * use eframe 0.20.1 in Cargo.toml * Update eframe/egui and wasm-bindgen * downgrade toml crate to avoid duplicate crate * document deny.toml * Update to wasm-bindgen-cli v0.2.84 everywhere * Publish new ci_docker image with wasm-bindgen-cli 0.2.84 * Better comment in deny.toml * Remove some unused crates found with cargo udeps * build fix (re-add unindent crate) commit 9f1452d Author: Emil Ernerfeldt <emil@rerun.io> Date: Thu Feb 9 09:51:55 2023 +0100 Improve the dev docs and top-level README.md (#1133) * Create a BUILD.md and CODE_STYLE.md * Move docs about how to build docs to BUILD.md * Improve example docs * Remove `python -m rerun` instructions (`rerun` should work just as well) * Explain justfile * Explain taplo.toml * Create dummy ARCHITECTURE.md and interlink all dev-docs * Start filling out ARCHITECTURE.md * Strip down README.md to its minimum * Document some of the major technologies * "Wasm" should not be written as WASM * Add a section about immediate mode * Add link to benchmarks * Fix link in TODO * Add list of shortcomings * a short section about the native viewer Co-authored-by: Jeremy Leibs <jeremy@rerun.io> * Improve the buisness model section Co-authored-by: Nikolaus West <niko@grapic.co> * User feedback * Unrelated code cleanup --------- Co-authored-by: Jeremy Leibs <jeremy@rerun.io> Co-authored-by: Nikolaus West <niko@grapic.co> * lost a glam reexport in translation * minimal python example with color cube * minimal rust example with color cube * saying goodbye to hello_world * requirements, fmt... * squash merge main commit 9108c86 Author: Clement Rey <cr.rey.clement@gmail.com> Date: Thu Feb 9 11:32:39 2023 +0100 The main `rerun` crate is now the public facing SDK (#1151) * main rerun crate now exposes the SDK * the sdk shall never depend directly on eframe * SDK crate is now mostly for internal use -> re_sdk * make sdk feature on by default * how did that guy get in * using new feature flag for optional dep thing * grabbing the SDK through 'rerun' implies access to the viewer * fmt * carrying glam aaaallll the way * addressed PR comments commit 025dbe3 Author: Andreas Reich <andreas@rerun.io> Date: Thu Feb 9 11:06:12 2023 +0100 Fix incorrectly logged warnings on paths missing from the entity tree. (#1147) Reasoning detailed in the code comments. Took the opportunity to do a clarifying rename. commit e7139d2 Author: Emil Ernerfeldt <emil@rerun.io> Date: Thu Feb 9 10:45:21 2023 +0100 Replace `nb_things` with `num_things` (#1162) * Replace `nb_things` with `num_things` Also adds a lint against it. Motivation: https://twitter.com/ernerfeldt/status/1622620902297837572 I went with `num_` here because it was the smaller change. * Add tests to lint.py * py-format * merge fix * chmod fix commit d5b822c Author: Emil Ernerfeldt <emil@rerun.io> Date: Thu Feb 9 09:52:55 2023 +0100 Update some crates in anticipation of egui 0.21 (#1154) * Make sure we never depend on cmake * Update to pollster 0.3 * Remove text-to-speech-related dependencies They shouldn't be needed, since we don't use tts * Use workspace versions of egui and eframe * use eframe 0.20.1 in Cargo.toml * Update eframe/egui and wasm-bindgen * downgrade toml crate to avoid duplicate crate * document deny.toml * Update to wasm-bindgen-cli v0.2.84 everywhere * Publish new ci_docker image with wasm-bindgen-cli 0.2.84 * Better comment in deny.toml * Remove some unused crates found with cargo udeps * build fix (re-add unindent crate) commit 9f1452d Author: Emil Ernerfeldt <emil@rerun.io> Date: Thu Feb 9 09:51:55 2023 +0100 Improve the dev docs and top-level README.md (#1133) * Create a BUILD.md and CODE_STYLE.md * Move docs about how to build docs to BUILD.md * Improve example docs * Remove `python -m rerun` instructions (`rerun` should work just as well) * Explain justfile * Explain taplo.toml * Create dummy ARCHITECTURE.md and interlink all dev-docs * Start filling out ARCHITECTURE.md * Strip down README.md to its minimum * Document some of the major technologies * "Wasm" should not be written as WASM * Add a section about immediate mode * Add link to benchmarks * Fix link in TODO * Add list of shortcomings * a short section about the native viewer Co-authored-by: Jeremy Leibs <jeremy@rerun.io> * Improve the buisness model section Co-authored-by: Nikolaus West <niko@grapic.co> * User feedback * Unrelated code cleanup --------- Co-authored-by: Jeremy Leibs <jeremy@rerun.io> Co-authored-by: Nikolaus West <niko@grapic.co> * merge conflict * Session::show docstring * addressed PR comments Co-authored-by: Emil Ernerfeldt <emil@rerun.io> * use new ColorRGBA constructors everywhere --------- Co-authored-by: Emil Ernerfeldt <emil@rerun.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Misc crate updates in preparation for egui release
Checklist
CHANGELOG.md
(if this is a big enough change to warrant it)