Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document: subjects subdivision #2808

Merged
merged 1 commit into from
May 9, 2022
Merged

document: subjects subdivision #2808

merged 1 commit into from
May 9, 2022

Conversation

zannkukai
Copy link
Contributor

Adds possibility to have subject subdivisions for local subject.
Refactoring document subjects management and rendering.

Closes #2455.
Closes #2609.
Closes #1869.

Co-Authored-by: Renaud Michotte renaud.michotte@gmail.com

Dev notes

Need a complete Document resource reindex after rebuilding the ES mapping.

How to test?

image
image

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@zannkukai zannkukai added this to the v1.11.0 milestone Apr 1, 2022
@zannkukai zannkukai self-assigned this Apr 1, 2022
@github-actions github-actions bot added dev: DB Database structure (models.py) f: data About data model, importation, transformation, exportation of data, specific for bibliographic data f: data migration Data migration from a legacy system or a previous version f: search labels Apr 1, 2022
@zannkukai zannkukai mentioned this pull request Apr 1, 2022
Merged
7 tasks
@zannkukai zannkukai force-pushed the zan-fix-issue-2455 branch 4 times, most recently from f5cf1f1 to 662c757 Compare April 3, 2022 14:00
jma
jma approved these changes Apr 5, 2022
View reviewed changes
Copy link
Contributor

@jma jma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job.

rero_ils/modules/documents/commons/subjects.py Show resolved Hide resolved
rero_ils/modules/documents/commons/subjects.py Show resolved Hide resolved
rero_ils/modules/documents/commons/subjects.py Outdated Show resolved Hide resolved
rero_ils/modules/documents/commons/subjects.py Outdated Show resolved Hide resolved
rero_ils/modules/documents/commons/subjects.py Show resolved Hide resolved
rero_ils/modules/documents/commons/subjects.py Outdated Show resolved Hide resolved
rero_ils/modules/documents/serializers.py Show resolved Hide resolved
rero_ils/modules/documents/serializers.py Show resolved Hide resolved
rero_ils/modules/documents/serializers.py Show resolved Hide resolved
tests/ui/documents/test_subjects.py Outdated Show resolved Hide resolved
@zannkukai zannkukai mentioned this pull request Apr 19, 2022
Closed
rerowep
rerowep approved these changes Apr 25, 2022
View reviewed changes
rero_ils/modules/documents/api.py Show resolved Hide resolved
@zannkukai zannkukai force-pushed the zan-fix-issue-2455 branch 5 times, most recently from dbb0d26 to ad2241f Compare May 5, 2022 12:06
@zannkukai zannkukai force-pushed the zan-fix-issue-2455 branch from ad2241f to 22aef53 Compare May 5, 2022 13:27
@zannkukai
document: subjects subdivision
15ea7d1 
Adds possibility to have subject subdivisions for local subject.
Refactoring document subjects management and rendering.

Closes rero#2455.
Closes rero#2609.
Closes rero#1869.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai force-pushed the zan-fix-issue-2455 branch from 22aef53 to 15ea7d1 Compare May 6, 2022 13:05
@zannkukai zannkukai merged commit 9fcf2e9 into rero:staging May 9, 2022
@zannkukai zannkukai deleted the zan-fix-issue-2455 branch May 9, 2022 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lauren-d lauren-d lauren-d approved these changes

@rerowep rerowep rerowep approved these changes

@BadrAly BadrAly BadrAly approved these changes

@jma jma jma approved these changes

@Garfield-fr Garfield-fr Awaiting requested review from Garfield-fr

@vgranata vgranata Awaiting requested review from vgranata

Assignees

@zannkukai zannkukai

Labels
dev: DB Database structure (models.py) f: data migration Data migration from a legacy system or a previous version f: data About data model, importation, transformation, exportation of data, specific for bibliographic data f: search
Projects
None yet
Milestone
v1.11.0
5 participants
@zannkukai @jma @BadrAly @rerowep @lauren-d