document: subject subdivisions display

[zannkukai]

Co-authored-by: Renaud Michotte renaud.michotte@gmail.com

Dependencies

rero/rero-ils#2808

How to test?

Code review check list

• Commit message template compliance.
• Commit message without typos.
• File names.
• Functions names.
• Functions docstrings.
• Unnecessary commited files?
• Cypress tests successful?

[ManaDeweerdt]

• [not linked??] Public view: wrong display of the document type. Ex: https://ilsdev.test.rero.ch/global/documents/708
  
  • NPR/05.05: ok!
• When adding a subdivision, it should be expanded (no need to click on the + sign)
  • NPR/05.05: ok!
    
• When adding a new subdivision, it must be placed below the existing subdivisions (not before).
  • NPR/05.05: ok!
• The subdivisions do not seem to be indexed.
  • NPR/05.05: ok!
• Subjetcs facet : the subdivisions should create a distinct value in the facet. This is not the case.
  • NPR/05.05: in my opinion, each subdivision should be a distinct facet value, which is not the case. To clarify.
    
• The import should be change to add those new specifications.
• Performance : adding subjects and subdivisions takes quite some time.
  • NPR/05.05: between 6-7 seconds when you add/remove a second value of the same subdivision
• NPR/05.05: In the tooltip (JSON schema descriptions), the MARC references are not given (there were specified in the issue). Is it on purpose?
• NPR/05.05: Document detailed view (professional interface), links to corporate bodies (bf:Organisation) are not displayed
  

[zannkukai]

Subjetcs facet : the subdivisions should create a distinct value in the facet. This is not the case.

Is it right ? it seems very strange for me. Take this exemple :

• You create a subject#S1 for the document#D1. This is a local concept subject without subdivision. The main term is "toto".
• You create a subject#S2 for the document#D2. This is a local concept subject with subdivisions. The main term is the same than S1 :: "toto". The temporal subdivision is "2022".

If I choose your proposition, both subject will be independent facet values : one on "toto", other on "toto - 2022". If user click on "toto" facet value, then it doesn't retrieve the Document#D2 (but this document has also define the "toto" subject... but with a subdivision).

Additionally, the facet displayed value will be often very long to be displayed on one line.
What's the PO team feeling about this problem ?

[zannkukai]

The subdivisions do not seem to be indexed.

Yes, they are (in localhost). But not into subject facet values.