data: set several minLength to 1 #1479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BadrAly
added
pilot libraries
f: editor
BadrAly
force-pushed
the
baa-min-length-fields
branch
from
8e49c2e to
934492f
Compare
benerken
approved these changes
Nov 20, 2020
iGormilhit
added
f: data
iGormilhit
suggested changes
Nov 23, 2020
There was a problem hiding this comment.
Commit message proposition:
data: set several minLength to 1
Sets the minimum length of the following fields to 1 character:
* patron.city
* patron.postal_code
* patron.street
* item.barcode
Co-Authored-by: Aly Badr <aly.badr@rero.ch>
And a small explanation on why it's needed would be fine. Is it to reflect the actual data?
pronguen
approved these changes
Nov 23, 2020
For migrating records from Virtua: Sets the minimum length of the following fields to 1 character: * patron.city * patron.postal_code * patron.street * item.barcode Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly
force-pushed
the
baa-min-length-fields
branch
from
934492f to
4a419e4
Compare
BadrAly
changed the title
iGormilhit
approved these changes
Nov 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For migrating records from Virtua: Sets the
minimum length of the following fields to 1 character:
Co-Authored-by: Aly Badr aly.badr@rero.ch
Why are you opening this PR?
https://tree.taiga.io/project/rero21-reroils/task/1884?kanban-status=1224895
Dependencies
My PR depends on the following
rero-ils-ui's PR(s):How to test?
Code review check list