notes: allow notes of short size #1476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BadrAly
added
the
f: editor
BadrAly
force-pushed
the
baa-notes-fields
branch
from
e735a27 to
94e0b9b
Compare
benerken
approved these changes
Nov 20, 2020
zannkukai
approved these changes
Nov 20, 2020
iGormilhit
added
f: data
iGormilhit
suggested changes
Nov 23, 2020
Sets the note minimum length of holdings, patron and item to 1 instead of 3 characters, to allow libraries to use notes as codes for some internal uses cases. Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly
force-pushed
the
baa-notes-fields
branch
from
94e0b9b to
28ffa6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets the note minimum length of holdings, patron and item to 1 instead
of 3 characters, to allow libraries to use notes as codes for some
internal uses cases.
Co-Authored-by: Aly Badr aly.badr@rero.ch
Why are you opening this PR?
https://tree.taiga.io/project/rero21-reroils/task/1880?kanban-status=1224895
Dependencies
My PR depends on the following
rero-ils-ui's PR(s):How to test?
You can not add holdings/patron/item notes of size
1Code review check list