Skip to content

Prevent modifying request by reference #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pedrobranco wants to merge 1 commit into from
Closed

Prevent modifying request by reference #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,19 +6,21 @@ module.exports = exports = function(request, log) {
log = log || exports.log

var proto
if (request.Request) {
proto = request.Request.prototype
} else if (request.get && request.post) {

if (!request.Request && request.get && request.post) {
// The object returned by request.defaults() doesn't include the
// Request property, so do this horrible thing to get at it. Per
// Wikipedia, port 4 is unassigned.
var req = request('http://localhost:4').on('error', function() { })
proto = req.constructor.prototype
var Request = request('http://localhost:4').on('error', function() { })
request.Request = Object.assign({}, Request);
request.Request.prototype = Object.assign({}, Request.prototype);
} else {
throw new Error(
"Pass the object returned by require('request') to this function.")
"Pass the object returned by require('request').defaults({}) to this function.")
}

proto = request.Request.prototype

if (!proto._initBeforeDebug) {
proto._initBeforeDebug = proto.init

Expand Down